chore: DevOps mvn install fail early

[CharlesDuboisSAP]

Context

mvn install should fail as fast as possible regardless of what step fails.

Feature scope:

• Organized plugins by phase (cosmetic)
• Moved SpotBugs to run after Jacoco (it never fails and takes a while, it is now in last)

[CharlesDuboisSAP]

SpotBugs is last after Jacoco

[MatKuhr]

This is not suitable when doing PoCs or larger refactorings. There we don't want to fix all PMD and Javadoc requirements just to compile.

Instead, if you want to run all checks fast (i.e. before/without tests), just run mvn install -DskipTests or create an alias for that. Compile takes around 10s (on my machine), so there is no point in moving checks to before that for speed

[CharlesDuboisSAP]

This is not suitable when doing PoCs or larger refactorings. There we don't want to fix all PMD and Javadoc requirements just to compile.

CheckStyle and PMD still run after compile.

[MatKuhr]

Okay fair, but still it's beneficial to run tests without fixing all javadoc warnings, why not just mvn install -DskipTests? our CI/CD pipeline does that already anyway..

[CharlesDuboisSAP]

Okay fair, but still it's beneficial to run tests without fixing all javadoc warnings, why not just mvn install -DskipTests? our CI/CD pipeline does that already anyway..

I run tests with IntelliJ, the only time I run mvn install is to make sure my PR is green

Reverted changes

[MatKuhr]

what does this change do?

[CharlesDuboisSAP]

It's redundant, the default is already initialize

[MatKuhr]

lgtm