-
Notifications
You must be signed in to change notification settings - Fork 15
chore: DevOps mvn install fail early
#324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| <artifactId>maven-resources-plugin</artifactId> | ||
| <version>3.3.1</version> | ||
| <groupId>com.github.spotbugs</groupId> | ||
| <artifactId>spotbugs-maven-plugin</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SpotBugs is last after Jacoco
mvn install fail earlymvn install fail early
MatKuhr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not suitable when doing PoCs or larger refactorings. There we don't want to fix all PMD and Javadoc requirements just to compile.
Instead, if you want to run all checks fast (i.e. before/without tests), just run mvn install -DskipTests or create an alias for that. Compile takes around 10s (on my machine), so there is no point in moving checks to before that for speed
CheckStyle and PMD still run after compile. |
|
Okay fair, but still it's beneficial to run tests without fixing all javadoc warnings, why not just |
I run tests with IntelliJ, the only time I run |
| <goals> | ||
| <goal>prepare-agent</goal> | ||
| </goals> | ||
| <phase>initialize</phase> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this change do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's redundant, the default is already initialize
MatKuhr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Context
mvn installshould fail as fast as possible regardless of what step fails.Feature scope: