Skip to content

chore: Enable E2E test for OpenAI models #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
newtork merged 3 commits into from
Feb 26, 2025
Merged

chore: Enable E2E test for OpenAI models #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bd0534
Initial
a-d Feb 26, 2025
512ab93
Formatting
bot-sdk-js Feb 26, 2025
41456e1
Merge branch 'main' into enable-e2e-test
newtork Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...ation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ public record OpenAiModel(@Nonnull String name, @Nullable String version) implem
/** Azure OpenAI GPT-4o Mini chat completions model */
public static final OpenAiModel GPT_4O_MINI = new OpenAiModel("gpt-4o-mini", null);

/** Azure OpenAI GPT-o3 Mini chat completions model */
public static final OpenAiModel GPT_O3_MINI = new OpenAiModel("o3-mini", null);

/** Azure OpenAI GPT-o1 chat completions model */
public static final OpenAiModel GPT_O1 = new OpenAiModel("o1", null);

/** Azure OpenAI Text Embedding 3 Large model */
public static final OpenAiModel TEXT_EMBEDDING_3_LARGE =
new OpenAiModel("text-embedding-3-large", null);
Expand Down
7 changes: 3 additions & 4 deletions sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/ScenarioTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,13 @@
import lombok.SneakyThrows;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.DisabledIfSystemProperty;

class ScenarioTest {

@Test
@DisplayName("Declared OpenAI models must match AI Core's available OpenAI models")
@DisplayName(
"Declared OpenAI models must be superset of our AI Core account's available OpenAI models")
@SneakyThrows
@DisabledIfSystemProperty(named = "aicore.landscape", matches = "canary")
void openAiModelAvailability() {

// Gather AI Core's list of available OpenAI models
Expand All @@ -41,6 +40,6 @@ void openAiModelAvailability() {
}

// Assert that the declared OpenAI models match the expected list
assertThat(declaredOpenAiModelList).hasSameElementsAs(availableOpenAiModels);
assertThat(declaredOpenAiModelList).containsAll(availableOpenAiModels);
}
}
Loading