Skip to content

Conversation

@newtork
Copy link
Contributor

@newtork newtork commented Feb 27, 2025

No description provided.

@newtork newtork changed the title Use functional interfaces instead of class Use functional interface currying Feb 27, 2025
Copy link
Member

@Jonas-Isr Jonas-Isr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jonas-Isr Jonas-Isr merged commit 42d7d22 into orch-schema-convenience Feb 27, 2025
3 of 4 checks passed
@Jonas-Isr Jonas-Isr deleted the orch-schema-convenience2 branch February 27, 2025 16:32
Jonas-Isr added a commit that referenced this pull request Feb 28, 2025
* Use library to generate schemas from java classes

* Create ResponseJsonSchema and adapt OrchestrationModuleConfig

* Add additional tests, reset TestCoverage

* Add documentation etc.

* Small fixes

* Improve documentation

* Requested changes

* Update orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationModuleConfig.java

Co-authored-by: Charles Dubois <[email protected]>

* Small fix

* WIP

* Introduce new class TemplateConfig and adapt tests

* Adding javadocs and annotations

* Add tests

* Update docs/guides/ORCHESTRATION_CHAT_COMPLETION.md

Co-authored-by: Alexander Dümont <[email protected]>

* Small changes

* Update orchestration/src/main/java/com/sap/ai/sdk/orchestration/ResponseJsonSchema.java

Co-authored-by: Alexander Dümont <[email protected]>

* Formatting

* Use functional interfaces instead of class (#357)

Co-authored-by: Alexander Dümont <[email protected]>
Co-authored-by: Jonas-Isr <[email protected]>

* Requested changes

* change @SInCE to 1.4.0

* rename factory methods

* small fix

* small fix.finalfinal

---------

Co-authored-by: Jonas Israel <[email protected]>
Co-authored-by: Charles Dubois <[email protected]>
Co-authored-by: Alexander Dümont <[email protected]>
Co-authored-by: SAP Cloud SDK Bot <[email protected]>
Co-authored-by: Alexander Dümont <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants