chore: [OpenAI] use code generation #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 4, 2025
CharlesDuboisSAP
previously approved these changes
Mar 5, 2025
rpanackal
previously requested changes
Mar 6, 2025
...om/sap/ai/sdk/foundationmodels/openai/generated/model/ChatCompletionResponseMessageRole.java
Show resolved
Hide resolved
rpanackal
reviewed
Mar 6, 2025
.../foundationmodels/openai/generated/model/CreateChatCompletionStreamResponseChoicesInner.java
Show resolved
Hide resolved
# Conflicts: # .pipeline/spotbugs-exclusions.xml
Jonas-Isr
reviewed
Apr 17, 2025
Comment on lines
-161
to
+173
| public boolean equals(@Nullable final Object o) { | ||
| public boolean equals(@Nullable final java.lang.Object o) { |
Member
There was a problem hiding this comment.
(Question)
Why is this change necessary/happening?
Contributor
Author
There was a problem hiding this comment.
Interesting. Our generator has always (i.e. 2+ years) generated java.lang.Object.
What happened?
My assumption is: When I originally pushed the model classes, I generated them once in Cloud SDK repo. Then I moved them to AI SDK. Very likely, IntelliJ did some reduction / unintentional improvement, to remove the redundant FQN for Object.
Why would we want
java.lang.Objectin the first place?
Because some schema components may be called "Object" in the spec, leading to "Object" being generated. It's not a reserved keyword in java. Therefore, safest approach is to reference everything with fully-qualified-name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked Waiting for release of SAP Cloud SDK
5.18.0Context
https://github.com/SAP/ai-sdk-java-backlog/issues/171
Generate OpenAI 2024-10-21 automatically
Depends on SAP/cloud-sdk-java#745
Feature scope:
Definition of Done
Tests cover the scope aboveError handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated