-
Notifications
You must be signed in to change notification settings - Fork 15
feat: Moved documentation to portal #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, have obviously not checked the whole content of the new documentation platform though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GitHub Releases arent dependent this markdown, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand, it depends on docs/release-notes/release_notes.md, which is fine.
Jonas-Isr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jonas-Isr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After thinking about it, do we not have to change the python script release_notes_automation here to not create the release-notes-X-to-Y in this repo again? Or will that be handled in a separate PR?
Context
AI/ai-sdk-java-backlog#218.
We moved the documentation from here to the documentation portal
Feature scope:
Definition of Done
Tests cover the scope aboveError handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDK