Skip to content

Conversation

@TillK17
Copy link
Contributor

@TillK17 TillK17 commented Mar 12, 2025

Context

AI/ai-sdk-java-backlog#206

  • added new models o1 and o3-mini to OrchestrationAiModel and OpenAiModel
  • tested new parameter reasoning effort of o-series in bruno and SDK (works well, with high effort ~double the token consumption of low effort)
  • deprecated models according to SAP Note and added retirement date and suggested replacement model to javadoc

Feature scope:

  • All available models from the SDK are aligned with the SAP notes.
  • Both OpenAI client and orchestration client are covered
  • Test if new, additional model params for the new models already work. If not, create a follow-up ticket

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

@TillK17 TillK17 added the please-review Request to review a pull-request label Mar 12, 2025
Comment on lines +143 to +144
* @deprecated This model is deprecated on AI Core with a planned retirement on 2025-05-13. The
* suggested replacement model is {@link OrchestrationAiModel#GPT_4O}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Question)

Just to confirm, we want to expose this dynamic information (deprecation date and replacement), rather than suggesting SAP Note directly? @jjtang1985?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was initially proposed by Till.
From consumer perspective, it's convenient to have this information as Java annotation.
If it does not cost too much time, I would like to have them.

/** Azure OpenAI GPT-4o-mini chat completions model */
public static final OrchestrationAiModel GPT_4O_MINI = new OrchestrationAiModel("gpt-4o-mini");

/** Azure OpenAI o1 chat completions model */
Copy link
Contributor

@newtork newtork Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Question)

Why do you remove "chat completion" from JavaDoc in other places but add it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I believe I wasnt 100% consistent with this.

I initially noticed that some models had a chat completion or embedding in their JavaDoc, others not. As many of the newer models are generally multimodal, I found the chat completion a bit misleading. However, for our SDK, they can of course only generate text or cumpute embeddings (except from dall-e).

Copy link
Member

@rpanackal rpanackal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CharlesDuboisSAP CharlesDuboisSAP merged commit fe492d0 into main Mar 13, 2025
6 checks passed
@CharlesDuboisSAP CharlesDuboisSAP deleted the update-available-modellist branch March 13, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please-review Request to review a pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants