test: [OpenAI] E2E Tool Call Execution #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlesDuboisSAP
requested changes
Mar 18, 2025
Contributor
CharlesDuboisSAP
left a comment
CharlesDuboisSAP
left a comment
There was a problem hiding this comment.
You should remove the old tools endpoint chatCompletionTools, it has no purpose anymore
sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OpenAiController.java
Outdated
Show resolved
Hide resolved
sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OpenAiService.java
Outdated
Show resolved
Hide resolved
sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OpenAiService.java
Show resolved
Hide resolved
sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OpenAiService.java
Outdated
Show resolved
Hide resolved
sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/services/OpenAiServiceV2.java
Outdated
Show resolved
Hide resolved
sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/services/OpenAiServiceV2.java
Outdated
Show resolved
Hide resolved
sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/services/OpenAiServiceV2.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Mar 18, 2025
…nai/tool-call-execute
- Mostly tested - API design complete - Function Call as message content item - Non nullability of `Message.content()`
…nai/tool-call-execute
…nai/tool-call-execute
…nai/tool-call-execute
…nai/tool-call-execute # Conflicts: # sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/services/OpenAiServiceV2.java
- OpenAiAssistantMessage().content() may contain empty list
- final keyword - remove redundant assertion - variable naming
…nai/tool-call-execute # Conflicts: # sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/services/OpenAiServiceV2.java
- final keyword - variable naming
javadoc and naming Co-authored-by: Charles Dubois <[email protected]>
…nai/tool-call-execute
…P/ai-sdk-java into feat/openai/tool-call-execute
…nai/tool-call-execute
refactor sample code
newtork
reviewed
Apr 3, 2025
sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OpenAiController.java
Outdated
Show resolved
Hide resolved
…nai/tool-call-execute
CharlesDuboisSAP
previously approved these changes
Apr 3, 2025
CharlesDuboisSAP
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#213.
Previously the e2e only included the initial request for tool call. We are now adding additional e22e test for the second interaction after tool execution.
Note: Docs updated on SAP/ai-sdk#24
Definition of Done
Error handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated