test: SpringAI Filtering #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 7, 2025 10:46
TillK17
commented
Apr 7, 2025
...ation/src/main/java/com/sap/ai/sdk/orchestration/spring/OrchestrationSpringChatResponse.java
Outdated
Show resolved
Hide resolved
TillK17
commented
Apr 7, 2025
...-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/SpringAiOrchestrationService.java
Outdated
Show resolved
Hide resolved
TillK17
commented
Apr 7, 2025
| .getOutputFiltering(); | ||
| assertThat(filterResult.getMessage()).containsPattern("0 of \\d+ choices failed"); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Strict tests for hitting filters and lenient tests for non-hitting filters
rpanackal
reviewed
Apr 8, 2025
...spring-app/src/main/java/com/sap/ai/sdk/app/controllers/SpringAiOrchestrationController.java
Show resolved
Hide resolved
rpanackal
previously approved these changes
Apr 15, 2025
Member
rpanackal
left a comment
rpanackal
left a comment
There was a problem hiding this comment.
LGTM. If you switch back to OpenAI model use, let me know so I can simply reapprove.
...-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/SpringAiOrchestrationService.java
Outdated
Show resolved
Hide resolved
...-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/SpringAiOrchestrationService.java
Outdated
Show resolved
Hide resolved
…es/SpringAiOrchestrationService.java Co-authored-by: Roshin Rajan Panackal <[email protected]>
newtork
approved these changes
Apr 16, 2025
Contributor
|
I ran and tested it locally. Success 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#224
Feature scope:
Definition of Done
Aligned changes with the JavaScript SDKRelease notes updated