Conversation
Jonas-Isr
commented
Apr 4, 2025
Comment on lines
+10
to
+11
| <Package name="com.sap.ai.sdk.prompt.registry.model"/> | ||
| <Package name="com.sap.ai.sdk.prompt.registry.client"/> |
Member
Author
There was a problem hiding this comment.
Drive-by fix: the generated code for prompt registry was not excluded from spotbugs.
newtork
reviewed
Apr 7, 2025
Comment on lines
58
to
61
| <module name="JavadocVariable"> | ||
| <property name="accessModifiers" value="protected"/> | ||
| <property name="accessModifiers" value="protected, public"/> | ||
| <property name="severity" value="info"/> | ||
| </module> |
Contributor
There was a problem hiding this comment.
That's a duplicate <module> right? 🤔
Member
Author
There was a problem hiding this comment.
Good catch! Is updated. Thanks :)
newtork
previously approved these changes
Apr 7, 2025
CharlesDuboisSAP
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Checkstyle's
scopekey works differently from itsaccessModifierskey: foraccessModifiersyou have to list all more general access levels as well, while forscopeit implies all access levels that are more general. This PR fixes our use ofaccessModifiers.Note: Something similar probably has to be done for Cloud SDK. There is a BLI here.