feat: [DevOps] Update grounding specification #445
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtork
changed the title
grounding specification
newtork
changed the title
grounding specification
newtork
previously requested changes
Jun 3, 2025
newtork
dismissed
their stale review
In fact we do use this PR. The API Hub spec is inconsistent. PO was notified, we'll ignore conflicts.
newtork
reviewed
Jun 3, 2025
Comment on lines
610
to
611
| operationId: vector.v1.vector_endpoints.get_all_documents | ||
| x-sap-cloud-sdk-operation-name: getAllDocuments | ||
| parameters: |
Contributor
There was a problem hiding this comment.
Why do our generated service method names look fubar? Because colleagues have removed our spec extension.
final var documents = CLIENT_VECTOR
- .getAllDocuments(RESOURCE_GROUP, collectionId);
+ .vectorV1VectorEndpointsGetAllDocuments(RESOURCE_GROUP, collectionId);
newtork
requested changes
Jun 5, 2025
Contributor
|
Close for renewal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Update grounding specification file based on main.
This PR was created automatically by the spec-update workflow.
You can commit on top of this branch, but as long as this PR is open the action can't be re-run.
Before merging, make sure to update tests and release notes, if necessary.
Definition of Done