Skip to content

Conversation

@rpanackal
Copy link
Member

@rpanackal rpanackal commented Jul 2, 2025

Context

AI/ai-sdk-java-backlog#284.

Integrating all v2 spec related changes that are oncoming.

  • Update main code
    • breaking changes in OrchestrationModuleConfig
  • Unit test adapted
  • Json payloads updated

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

bot-sdk-js and others added 18 commits May 26, 2025 11:10
…onse-type

# Conflicts:
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/DpiMasking.java
…ffix and Embedding property renaming (#469)

* Introduce filtering schema changes and update generated class names

- synchronous suffix removed
- `createConfig` removed from `ContentFilter`
- release notes updated for filtering changes

* Introduce filtering schema changes and update generated class names

- synchronous suffix removed
- `createConfig` removed from `ContentFilter`
- release notes updated for filtering changes

* Release notes and jacoco coverage work around

* Lower min required jacoco coverage complexity and branch rating.

- Release note paraphrasing

* Update e2e for input filters

---------

Co-authored-by: Roshin Rajan Panackal <[email protected]>
- `ConfigToRequestTransformer` (not fixed)
…onse-type

# Conflicts:
#	docs/release_notes.md
#	orchestration/pom.xml
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/JacksonMixins.java
#	sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java
…onse-type' into spec-update/orchestration/fix/validate-v2

# Conflicts:
#	sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java
Copy link
Contributor

@newtork newtork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today we reviewed spec changes and generated-code changes.
Tests need to be updated.

Base automatically changed from spec-update/orchestration/fix/streaming-response-type to main July 9, 2025 09:41
rpanackal and others added 4 commits July 23, 2025 10:34
…ate/orchestration/fix/validate-v2

# Conflicts:
#	docs/release_notes.md
#	orchestration/pom.xml
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/ContentFilter.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatCompletionDelta.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatResponse.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationClient.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationHttpExecutor.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationJacksonConfiguration.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/model/AzureContentSafetyInput.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/model/CompletionPostResponseStreaming.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/model/ErrorResponseStreaming.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/model/LLMModuleResult.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/spring/OrchestrationSpringChatDelta.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/spring/OrchestrationSpringChatResponse.java
#	orchestration/src/main/resources/spec/orchestration.yaml
#	orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java
#	sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java
@rpanackal rpanackal self-assigned this Jul 23, 2025
# Conflicts:
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/spring/OrchestrationChatOptions.java
@rpanackal rpanackal added the please-review Request to review a pull-request label Aug 4, 2025
# Conflicts:
#	docs/release_notes.md
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationError.java
#	orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java
Copy link
Contributor

@newtork newtork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@newtork newtork enabled auto-merge (squash) August 7, 2025 14:02
@newtork newtork merged commit b9150cb into main Aug 7, 2025
7 checks passed
@newtork newtork deleted the spec-update/orchestration/fix/validate-v2 branch August 7, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please-review Request to review a pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants