feat: Sample Code for MCP Support #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pom.xml # sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/SpringAiOrchestrationService.java
newtork
reviewed
Jul 24, 2025
Comment on lines
+16
to
+20
| command: npx | ||
| args: | ||
| - "-y" | ||
| - "@modelcontextprotocol/server-filesystem" | ||
| - "." |
Contributor
There was a problem hiding this comment.
(Comment)
It feels awkward to assume NodeJS runtime at a Java application container.
There's no real alternative, right?
Member
Author
There was a problem hiding this comment.
This is just an easy way to get a local MCP server that can be used as an example. Many MCP servers are just small node or python packages.
If we had a stable, external MCP server that does something useful for a small sample, we could also use that, but for now I didn't want to rely on a 3rd party server and rather go for a fully local setup.
newtork
reviewed
Jul 24, 2025
...-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/SpringAiOrchestrationService.java
Outdated
Show resolved
Hide resolved
newtork
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
SAP/ai-sdk-java-backlog#305
Adds sample code for MCP support. Disabled by default.
Feature scope:
npxto run)Definition of Done
Tests cover the scope aboveRelease notes updated