chore: [DevOps] Latest Grounding spec update check #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
rpanackal
changed the title
newtork
previously approved these changes
Aug 1, 2025
rpanackal
changed the title
rpanackal
added
please-review
rpanackal
commented
Aug 8, 2025
newtork
reviewed
Aug 8, 2025
...-services/document-grounding/src/main/java/com/sap/ai/sdk/grounding/model/ResultsInner3.java
Show resolved
Hide resolved
newtork
reviewed
Aug 8, 2025
| { | ||
| @JsonProperty("results") | ||
| private List<ResultsInner1> results = new ArrayList<>(); | ||
| private List<ResultsInner2> results = new ArrayList<>(); |
Contributor
There was a problem hiding this comment.
(Comment)
Okay we need a follow-up BLI to fix this is in pre-processing with adding/fixing title: FooBar to component schema.
Or we'll tell the maintainers to fix their spec with using unique titles.
newtork
reviewed
Aug 8, 2025
| * @throws OpenApiRequestException if an error occurs while attempting to invoke the API | ||
| */ | ||
| @Nonnull | ||
| public OpenApiResponse manualTriggerPipeline( |
Contributor
There was a problem hiding this comment.
(Question)
We don't have a pipeline integration test right? We may need a BLI if there isn't one already. Low priority.
newtork
reviewed
Aug 8, 2025
| */ | ||
| @Nonnull | ||
| public SearchResults search( | ||
| public VectorSearchResults search( |
Contributor
There was a problem hiding this comment.
(Comment)
Also here we may need a BLI for adding an integration test for vector searching. Low priority.
newtork
approved these changes
Aug 8, 2025
Contributor
newtork
left a comment
newtork
left a comment
There was a problem hiding this comment.
Otherwise LGTM, branch looks good according to our process standards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#ISSUENUMBER.
This PR carries the changes in
api_hub_merged_spec.yamlin the grounding service PR linked.Includes:
Other changes borrowed from some earlier PR, not merged in our main branch spec
DocumentStatusFeature scope:
Add new tests for the latest featuresRequires setting up s3 and sftp pipelinesDefinition of Done
Error handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDK