chore: [OpenAI] @Beta reduction and advertising new api
#552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--> Updating the OpenAiController to use updated OpenAiService class.
Contributor
Author
|
Documentation was carefully reviewed and tested locally , no updates needed as the navigation links navigate to the correct service class because the new service class has the same name as old one OpenAiService and old one was renamed to OpenAiServiceDeprecated. |
newtork
reviewed
Aug 26, 2025
sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OpenAiController.java
Show resolved
Hide resolved
newtork
reviewed
Aug 26, 2025
foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiClient.java
Show resolved
Hide resolved
newtork
reviewed
Aug 26, 2025
foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiClient.java
Show resolved
Hide resolved
newtork
reviewed
Aug 26, 2025
| * @param apiVersion the API version to target. | ||
| * @return a new client. | ||
| */ | ||
| @Beta |
Contributor
There was a problem hiding this comment.
(Minor)
Would keep Beta since this is for edge-cases (and we are not sure about implications?)
Contributor
CharlesDuboisSAP
left a comment
CharlesDuboisSAP
left a comment
There was a problem hiding this comment.
LGTM, I would still merge advertising-new-api2 into this branch
sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OpenAiController.java
Outdated
Show resolved
Hide resolved
* Stabilize request and response classes * Stabilize tool and embedding classes * Stabilize tool util
newtork
changed the title
@Beta reduction and advertising new api
newtork
changed the title
@Beta reduction and advertising new api @Beta reduction and advertising new api
…llers/OpenAiController.java
CharlesDuboisSAP
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--> Stabilizing the new api
With the exception of:
Context
AI/ai-sdk-java-backlog#280.
OpenAiController was using the old OpenAiService class and there were 2 service classes.
Feature scope:
Definition of Done
Tests cover the scope aboveError handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updated