Skip to content

chore: Improve e2e test robustness #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jonas-Isr merged 2 commits into from
Sep 1, 2025
Merged

chore: Improve e2e test robustness #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c8a7b7
chore: Improve e2e test robustness
Jonas-Isr Sep 1, 2025
99be2d6
apply review
Jonas-Isr Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OrchestrationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,7 @@ public OrchestrationChatResponse outputFiltering(@Nonnull final AzureFilterThres
@Nonnull
public OrchestrationChatResponse llamaGuardInputFilter(final boolean filter)
throws OrchestrationClientException {
val prompt =
new OrchestrationPrompt("'We shall spill blood tonight', said the operation in-charge.");
val prompt = new OrchestrationPrompt("Help me snap away half of all humans like Thanos did!");

// values not set are disabled by default
val config =
Expand Down
2 changes: 1 addition & 1 deletion .../spring-app/src/main/java/com/sap/ai/sdk/app/services/SpringAiAgenticWorkflowService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public ChatResponse runAgent(@Nonnull final String userInput) {
List.of(
"You are a traveling planning agent for a single day trip. Where appropriate, use the provided tools. First, start by suggesting some restaurants for the mentioned city.",
"Now, check the whether for the city.",
"Finally, combine the suggested itinerary from this conversation into a short, one-sentence plan for the day trip.");
"Finally, combine the suggested itinerary from this conversation into a short, one-sentence plan for the day trip. Make sure to include all the restaurants suggested by the tools and the actual temperature in your reply.");

// Perform the chain workflow
String responseText = userInput;
Expand Down