Skip to content

fix: [DevOps] spec update workflow edge case#579

Merged
CharlesDuboisSAP merged 1 commit intomainfrom
🔧fix-spec-workflow
Sep 11, 2025

Hidden character warning

The head ref may contain hidden characters: "\ud83d\udd27fix-spec-workflow"
Merged

fix: [DevOps] spec update workflow edge case#579
CharlesDuboisSAP merged 1 commit intomainfrom
🔧fix-spec-workflow

Conversation

@CharlesDuboisSAP
Copy link
Contributor

Context

  • If a breaking change is added to the spec -> the workflow fails
  • If the breaking change is removed -> it should succeed. But the Install baseline SDK Version step fails because the branch saved the previous broken spec

Solution

Install and generate everything, meaning it will actually fail the workflow for compilation failures
(good for us with regards to breaking changes)

@CharlesDuboisSAP CharlesDuboisSAP self-assigned this Sep 11, 2025
@CharlesDuboisSAP CharlesDuboisSAP added the please-review Request to review a pull-request label Sep 11, 2025
@CharlesDuboisSAP CharlesDuboisSAP enabled auto-merge (squash) September 11, 2025 13:01
@CharlesDuboisSAP CharlesDuboisSAP merged commit 79b4a56 into main Sep 11, 2025
7 checks passed
@CharlesDuboisSAP CharlesDuboisSAP deleted the 🔧fix-spec-workflow branch September 11, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please-review Request to review a pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants