Skip to content

fix: [DevOps] Spec update ignores Orchestration hotfix #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CharlesDuboisSAP merged 6 commits into from
Jan 26, 2026
Merged

fix: [DevOps] Spec update ignores Orchestration hotfix #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b7556c2
fix: [DevOps] Spec update ignores Orchestration hotfix
CharlesDuboisSAP Jan 22, 2026
cd9ca13
workflow dispatch
CharlesDuboisSAP Jan 22, 2026
a550ef6
Fix Slack notif
CharlesDuboisSAP Jan 22, 2026
c24d495
Fix Slack notif 2
CharlesDuboisSAP Jan 22, 2026
b8b074e
I give up
CharlesDuboisSAP Jan 22, 2026
3abadcd
cleanup
CharlesDuboisSAP Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/spec-update.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ jobs:
- [ ] Release notes updated
") && echo "pr_url=$PR_URL" >> "$GITHUB_OUTPUT"

- name: Generate Job Summary
- name: "Generate Job Summary"
if: ${{ always() }}
env:
BRANCH: ${{ steps.branch.outputs.branch }}
Expand Down Expand Up @@ -245,7 +245,7 @@ jobs:
exit 1

- name: "Slack Notification"
if: failure() && github.event.inputs.create-pr == true
if: failure() && github.event.inputs.create-pr == 'true'
Copy link
Contributor Author

@CharlesDuboisSAP CharlesDuboisSAP Jan 22, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test run with slack notif.
It's evil that a type: boolean is actually a string

Copy link
Member

@Jonas-Isr Jonas-Isr Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

uses: slackapi/slack-github-action@v2.1.1
with:
webhook: ${{ secrets.SLACK_WEBHOOK }}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/weekly-spec-update.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: "Weekly Spec Update"
on:
schedule:
- cron: '0 0 * * SUN' # Every Sunday at midnight UTC
workflow_dispatch:

jobs:
update-all-specs:
Expand Down Expand Up @@ -41,6 +42,8 @@ jobs:
run: |
BRANCH="main"
if [ "${{ matrix.file }}" = "orchestration" ]; then
# remove hotfix suffix 0.110.13-2 -> 0.110.13
ORCH_VERSION=$(echo "$ORCH_VERSION" | sed 's/-.*//')
BRANCH="rel-$ORCH_VERSION"
fi
echo "Using branch: $BRANCH"
Expand Down
Loading