feat: Update orchestration specification#1646
Open
github-actions[bot] wants to merge 5 commits intomainfrom
Open
feat: Update orchestration specification#1646github-actions[bot] wants to merge 5 commits intomainfrom
github-actions[bot] wants to merge 5 commits intomainfrom
Conversation
davidkna-sap
previously requested changes
Mar 25, 2026
| @@ -22,7 +22,6 @@ export class OrchestrationEmbeddingResponse { | |||
| * @returns Array of embedding data objects containing both vectors, indices, and object types. | |||
| */ | |||
| getEmbeddings(): EmbeddingData[] { | |||
Member
There was a problem hiding this comment.
I considered adding an argument here to return a specific embedding for multi-embedding, but decided against it (e.g. getEmbeddings('float') only support for multi-embeddings). I have an implementation locally and could push it if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Update orchestration specification file based on rel-0.115.19.
This PR was created automatically by the spec-update workflow.
You can commit on top of this branch, but as long as this PR is open the action can't be re-run.
Before merging, make sure to update tests and release notes, if necessary.
Definition of Done