fix: 🐛 [IOSSDKBUG-1337] wrap long text of action button in cardfooter#1471
fix: 🐛 [IOSSDKBUG-1337] wrap long text of action button in cardfooter#1471zzchao-1999 wants to merge 4 commits intoSAP:mainfrom
Conversation
There was a problem hiding this comment.
@zzchao-1999 What problem do you try to solve? Can you provide a before and after screenshots. Original version should support text wrapping for buttons.
|
|
||
| let subViewSizes = subviews.reversed().map { | ||
| $0.sizeThatFits(proposal) | ||
| // Use width-constrained proposal when calculating subview sizes to enable text wrapping |
There was a problem hiding this comment.
@zzchao-1999 This is not necessary since maxButtonWidth is always nil so far.
| // check if overflow should be shown | ||
| if numToShow < numButtons { | ||
| requiredFinalWidth += min(self.maxButtonWidth, overflowSize.width) + theSpacing | ||
| maxHeight = max(maxHeight, overflowSize.height) |
There was a problem hiding this comment.
@zzchao-1999 This is not needed since line 198 does this.
if numToHide > 0 {
maxHeight = max(maxHeight, overflowSize.height)
}
|
|
@zzchao-1999 Can you also check for iOS 26.2 if working? Looks to me the layout of the two buttons is not correct. There is a "overflow" icon to the right. See screenshot |
I double checked it, the long text wrap issue has been fixed by the commit on Jan. 6. Sorry, I'll close it. |
It seems that this is a new issue. I’ll check it and create a new ticket to fix it. |
|
The issue has been fixed by below checkin: |
4 participants
No description provided.