Skip to content

Add test covering the default retry behavior of HTTP client 5 #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatKuhr merged 2 commits into from
Nov 18, 2025
Merged

Add test covering the default retry behavior of HTTP client 5 #1004

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59a256d
Add test covering the default retry behavior of HTTP client 5
MatKuhr Nov 17, 2025
0a27b1f
formatting
MatKuhr Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...ava/com/sap/cloud/sdk/cloudplatform/connectivity/DefaultApacheHttpClient5FactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.sap.cloud.sdk.cloudplatform.connectivity;

import static com.github.tomakehurst.wiremock.client.WireMock.aResponse;
import static com.github.tomakehurst.wiremock.client.WireMock.get;
import static com.github.tomakehurst.wiremock.client.WireMock.getRequestedFor;
import static com.github.tomakehurst.wiremock.client.WireMock.ok;
Expand Down Expand Up @@ -213,6 +214,21 @@ void testProxyConfigurationIsConsidered()
}
}

@Test
@SneakyThrows
void verifyDefaultRetryMechanism()
{
WIRE_MOCK_SERVER.stubFor(get(urlEqualTo("/too-many-requests")).willReturn(aResponse().withStatus(429)));
WIRE_MOCK_SERVER.stubFor(get(urlEqualTo("/temporary-error")).willReturn(aResponse().withStatus(503)));

final HttpClient client = sut.createHttpClient();
client.execute(new HttpGet(WIRE_MOCK_SERVER.url("/too-many-requests")), ignored -> ignored);
client.execute(new HttpGet(WIRE_MOCK_SERVER.url("/temporary-error")), ignored -> ignored);

WIRE_MOCK_SERVER.verify(2, getRequestedFor(urlEqualTo("/too-many-requests")));
WIRE_MOCK_SERVER.verify(2, getRequestedFor(urlEqualTo("/temporary-error")));
}

@SneakyThrows
private void assertCannotBeExecutedInParallel(
@Nonnull final ClassicHttpRequest firstRequest,
Expand Down