feat: [OpenAPI] Customize apache request object before invocation#1129
Open
feat: [OpenAPI] Customize apache request object before invocation#1129
Conversation
…napi-apache # Conflicts: # datamodel/openapi/openapi-core-apache/src/main/java/com/sap/cloud/sdk/services/openapi/apache/apiclient/ApiClient.java # pom.xml
newtork
added
do not merge
Jonas-Isr
approved these changes
Mar 27, 2026
Member
Jonas-Isr
left a comment
Jonas-Isr
left a comment
There was a problem hiding this comment.
I like this! It looks pretty cool and should give us a clean solution to the GZIP problem.
Only one minor comment. Also would be interested in what the others think.
Comment on lines
+84
to
+86
| private static OpenApiResponseListener EMPTY_RESPONSE_LISTENER = r -> { | ||
| }; | ||
| private static UnaryOperator<ClassicRequestBuilder> EMPTY_REQUEST_CUSTOMIZER = r -> r; |
Member
There was a problem hiding this comment.
(Minor)
These 2 could be final I guess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for runtime customization of request builder object before the
ApiClientinvocation.Related:
Example:
static RptClient forDestination(@Nonnull final Destination destination) { final var apiClient = ApiClient.create(destination) .withObjectMapper(getDefaultObjectMapper()) + .withRequestCustomizer(request -> { + if(request.getPath().contains("/predict")) { + return request.addHeader("Accept-Encoding", "gzip"); + } + return request; + }); return new RptClient(new DefaultApi(apiClient)); }