Skip to content

feat: [OpenAPI] Improved OneOf Support #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MatKuhr merged 3 commits into from
Dec 10, 2024
Merged

feat: [OpenAPI] Improved OneOf Support #657

MatKuhr merged 3 commits into from
Dec 10, 2024

Conversation

@MatKuhr
Copy link
Member

@MatKuhr MatKuhr commented Dec 2, 2024 •
edited
Loading

Context

Follow up to #647, see this comment

Feature scope:

  • oneOf deserialization support without discriminators
  • remove @Type property from serialization
  • serialization test
  • general template improvements
  • easier template debugging via property

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Documentation updated
  • Release notes updated

@MatKuhr MatKuhr added please merge Request to merge a pull request please review Request to review a pull request labels Dec 2, 2024
MatKuhr
MatKuhr commented Dec 2, 2024
View reviewed changes
...e/src/main/java/com/sap/cloud/sdk/datamodel/openapi/sample/model/OneOfWithDiscriminator.java
public interface OneOfWithDiscriminator
{
public String getSodaType();
String getSodaType();
Copy link
Member Author

@MatKuhr MatKuhr Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public is redundant for interfaces

@MatKuhr MatKuhr mentioned this pull request Dec 2, 2024
Merged
4 tasks
CharlesDuboisSAP
CharlesDuboisSAP reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a PR in the AI SDK to see the removed mixIn

@MatKuhr
Copy link
Member Author

MatKuhr commented Dec 3, 2024

Can you create a PR in the AI SDK to see the removed mixIn

will do once #652 is merged to not have too many different generator changes applied in parallel

@CharlesDuboisSAP
Copy link
Contributor

CharlesDuboisSAP commented Dec 9, 2024

Can you create a PR in the AI SDK to see the removed mixIn

will do once #652 is merged to not have too many different generator changes applied in parallel

Done, let me know when the AI SDK PR is created

@MatKuhr MatKuhr mentioned this pull request Dec 9, 2024
Merged
@MatKuhr
Copy link
Member Author

MatKuhr commented Dec 9, 2024

Done

@MatKuhr MatKuhr merged commit 67ecf24 into main Dec 10, 2024
14 checks passed
@MatKuhr MatKuhr deleted the fix/one-of-type-annotations branch December 10, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@newtork newtork newtork left review comments

@CharlesDuboisSAP CharlesDuboisSAP CharlesDuboisSAP approved these changes

Assignees

No one assigned

Labels

please merge Request to merge a pull request please review Request to review a pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MatKuhr @CharlesDuboisSAP @newtork