[OData] Renamed internal variable values to cloudSdkValues
#668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlesDuboisSAP
added
please merge
CharlesDuboisSAP
changed the title
valuevalues to cloudSdkValues
MatKuhr
reviewed
Dec 17, 2024
Member
MatKuhr
left a comment
MatKuhr
left a comment
There was a problem hiding this comment.
Can we apply the same solution to OData v2?
| if( values.containsKey("Id") ) { | ||
| final Object value = values.remove("Id"); | ||
| if( cloudSdkValues.containsKey("Id") ) { | ||
| final Object value = cloudSdkValues.remove("Id"); |
Member
There was a problem hiding this comment.
The same problem still remains for value, doesn't it?
Contributor
Author
There was a problem hiding this comment.
I'm creating a new pull request for that as it's a much bigger change
MatKuhr
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
https://sap.stackenterprise.co/questions/65172
Users can't create an object with a field named
valuesand make a List or Map of this object.Solution: rename our internal variable from
valuestocloudSdkValuesto make sure it doesn't collide.Definition of Done
Documentation updated