OData V2 Nested Field Update #675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Recursive update of fields of complex properties - Facilitate both partial complex object and full complex json object creation logic - Update test code for correct json value type
- Partial complex object update - full complex object update - test for full complex object payload - new enum for patch request strategies
…complex-field-update
…ld-update' into odatav2-complex-field-update
newtork
reviewed
Dec 20, 2024
.../src/test/java/com/sap/cloud/sdk/datamodel/odata/helper/FluentHelperUpdateToRequestTest.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Dec 20, 2024
...ta-client/src/main/java/com/sap/cloud/sdk/datamodel/odata/client/request/UpdateStrategy.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Dec 20, 2024
...ta-client/src/main/java/com/sap/cloud/sdk/datamodel/odata/client/request/UpdateStrategy.java
Show resolved
Hide resolved
newtork
reviewed
Dec 20, 2024
...odata-core/src/main/java/com/sap/cloud/sdk/datamodel/odata/helper/ODataEntitySerializer.java
Show resolved
Hide resolved
newtork
reviewed
Dec 20, 2024
...odata-core/src/main/java/com/sap/cloud/sdk/datamodel/odata/helper/ODataEntitySerializer.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Dec 20, 2024
...odata-core/src/main/java/com/sap/cloud/sdk/datamodel/odata/helper/ODataEntitySerializer.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Dec 20, 2024
...odata-core/src/main/java/com/sap/cloud/sdk/datamodel/odata/helper/ODataEntitySerializer.java
Outdated
Show resolved
Hide resolved
- remove unwanted disabled tag on test - add best and since tag on java doc to all public api - code reduction on createPatchObjectRecursiveDelta - generalize containsNestedChangedFields with type validation - comment correction
newtork
reviewed
Dec 20, 2024
.../src/test/java/com/sap/cloud/sdk/datamodel/odata/helper/FluentHelperUpdateToRequestTest.java
Show resolved
Hide resolved
newtork
previously approved these changes
Dec 20, 2024
newtork
reviewed
Dec 23, 2024
…to odatav2-complex-field-update # Conflicts: # datamodel/odata-client/src/main/java/com/sap/cloud/sdk/datamodel/odata/client/request/ODataRequestBatch.java # datamodel/odata-client/src/main/java/com/sap/cloud/sdk/datamodel/odata/client/request/ODataRequestUpdate.java
newtork
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
SAP/ai-sdk-java-backlog
Introduce update of nested fields of complex types in OData PATCH request
Feature scope:
Definition of Done
Error handling created / updated & covered by the tests aboveRelease notes updated