fix(openapi-generator): Optionally generate @Beta annotation on interfaces
#688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtork
added
please merge
newtork
commented
Jan 10, 2025
| /** | ||
| * OneOf | ||
| */ | ||
| @Beta |
Contributor
Author
There was a problem hiding this comment.
(Comment)
This annotation was not generated before.
9 tasks
MatKuhr
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Issue found here
SAP/ai-sdk-java#267 (review)
Fix inconsistency, where all model classes marked as
@Betawith the exception of the anyof/oneof -based interfaces.Feature scope:
We maintain a feature toggle to mark generated code as "unstable".
But we forgot to consider interface types, that were introduced afterwards.
Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated(The generator behavior-change only applies when the feature toggle is active)