Skip to content

Conversation

@marikaner
Copy link
Contributor

While integrating dependabot PRs, I noticed, that we are weirdly using two versions of eslint (8 + 9). I don't see a reason why this was done and I assume, that this was by mistake. Let me know, if I missed something.

Copy link
Contributor

@ZhongpinWang ZhongpinWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZhongpinWang
Copy link
Contributor

Only one comment, do we need a changeset for this? As using ESLint9 potentially needs consumers to adapt some of their eslint rules (just like in this PR some eslint disable was removed/added).

Copy link
Collaborator

@KavithaSiva KavithaSiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like @ZhongpinWang said I think, adding a changeset with compatbility note is good, as eslint config from 8 to 9 is breaking, with the flat config structure.

@marikaner
Copy link
Contributor Author

Only one comment, do we need a changeset for this? As using ESLint9 potentially needs consumers to adapt some of their eslint rules (just like in this PR some eslint disable was removed/added).

Yes, I will add a changeset for the peer dependency update. With that users should be able to use eslint 9 without the --legacy-peer-deps flag.
Otherwise, I only changed dev dependencies and I did not change any lint rules. We now use eslint 9 consistently throughout the code, but that does not affect users.

@marikaner marikaner enabled auto-merge (squash) January 5, 2026 09:38
@marikaner marikaner merged commit 6431463 into main Jan 5, 2026
17 checks passed
@marikaner marikaner deleted the eslint9 branch January 5, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants