Skip to content

fix: adds a grey background to the dark themed images#13

Merged
jn-av merged 6 commits intomainfrom
testingemily
Mar 9, 2026
Merged

fix: adds a grey background to the dark themed images#13
jn-av merged 6 commits intomainfrom
testingemily

Conversation

@emilyscode1
Copy link
Copy Markdown
Contributor

@emilyscode1 emilyscode1 commented Mar 6, 2026

Description:

adds a grey background to the dark themed images, so the dark mode is working better now

Before:

Screenshot 2026-03-06 at 11 28 29

After:

Screenshot 2026-03-06 at 11 28 18

How:

we are doing it by adding an new directive :::image-light that can be used like this:

:::image-light
![Architecture overview](/img/contribution/Picture.png)
:::

@emilyscode1 emilyscode1 requested a review from jn-av March 6, 2026 10:30
@jn-av
Copy link
Copy Markdown
Member

jn-av commented Mar 6, 2026

Great PR, @emilyscode1! Thanks for the contribution.

One observation: the current implementation applies a gray background to every image in dark mode, which might not be ideal in all cases. I was thinking of introducing a specific container or directive, like :::image-light, so we can apply this styling selectively. For example:

:::image-light
![Setup Cloud Management Service](/img/overview-orchestrate-accounts.png)
:::

What do you think about this approach?

Copy link
Copy Markdown
Contributor Author

@emilyscode1 emilyscode1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the improvement :)

@jn-av jn-av requested a review from enrico-kaack-comp March 9, 2026 12:46
@jn-av jn-av merged commit e10ad2c into main Mar 9, 2026
5 checks passed
@jn-av jn-av deleted the testingemily branch March 9, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants