fix: adds a grey background to the dark themed images#13
Merged
Conversation
Member
|
Great PR, @emilyscode1! Thanks for the contribution. One observation: the current implementation applies a gray background to every image in dark mode, which might not be ideal in all cases. I was thinking of introducing a specific container or directive, like What do you think about this approach? |
emilyscode1
commented
Mar 9, 2026
Contributor
Author
emilyscode1
left a comment
There was a problem hiding this comment.
lgtm, thanks for the improvement :)
enrico-kaack-comp
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
adds a grey background to the dark themed images, so the dark mode is working better now
Before:
After:
How:
we are doing it by adding an new directive
:::image-lightthat can be used like this: