Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 0 additions & 49 deletions .eslintrc.json

This file was deleted.

4 changes: 2 additions & 2 deletions jest.config.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { getJestProjects } from '@nx/jest';
import { getJestProjectsAsync } from '@nx/jest';
import type { Config } from 'jest';

export default {
projects: getJestProjects(),
projects: await getJestProjectsAsync(),
transformIgnorePatterns: ['(.*)/node_modules/(?!(lodash-es)/?)']
} as Config;
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export class NavigationLinkComponent extends FdbNavigationItemLink implements On

/** @hidden */
@HostBinding('attr.tabindex')
private get _tabIndex(): number {
protected get _tabIndex(): number {
return this._listItemComponent?.popoverOpen$() || this._navigation.getActiveItem()?.link$() === this ? 0 : -1;
}

Expand Down Expand Up @@ -125,7 +125,7 @@ export class NavigationLinkComponent extends FdbNavigationItemLink implements On

/** @hidden */
@HostListener('click')
private _clickHandler(): void {
protected _clickHandler(): void {
if (this.inPopover || !this._listItemComponent?.isVisible$() || this._listItemComponent?.isOverflow$()) {
this._navigation.closePopups();
}
Expand All @@ -138,7 +138,7 @@ export class NavigationLinkComponent extends FdbNavigationItemLink implements On

/** @hidden */
@HostListener('keydown', ['$event'])
private _keyDownHandler(event: KeyboardEvent): void {
protected _keyDownHandler(event: KeyboardEvent): void {
if (this.inPopover && KeyUtil.isKeyCode(event, DOWN_ARROW)) {
this._listItemComponent?.popoverLinkArrowDown();
return;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ export class NavigationComponent
* Main keyboard navigation handler.
*/
@HostListener('keydown', ['$event'])
private _keyDownHandler(event: KeyboardEvent): void {
protected _keyDownHandler(event: KeyboardEvent): void {
if (!KeyUtil.isKeyCode(event, [UP_ARROW, DOWN_ARROW])) {
return;
}
Expand Down
3 changes: 2 additions & 1 deletion libs/btp/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
"options": {
"jestConfig": "libs/btp/jest.config.ts"
"jestConfig": "libs/btp/jest.config.ts",
"tsConfig": "libs/btp/tsconfig.spec.json"
}
}
}
Expand Down
1 change: 0 additions & 1 deletion libs/btp/tsconfig.lib.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"declaration": true,
"declarationMap": true,
"types": [],
"lib": ["dom", "es2020"],
"useDefineForClassFields": false,
"moduleResolution": "bundler"
},
Expand Down
3 changes: 2 additions & 1 deletion libs/cdk/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
"options": {
"jestConfig": "{projectRoot}/jest.config.ts"
"jestConfig": "{projectRoot}/jest.config.ts",
"tsConfig": "libs/cdk/tsconfig.spec.json"
}
}
}
Expand Down
1 change: 0 additions & 1 deletion libs/cdk/tsconfig.lib.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"declaration": true,
"declarationMap": true,
"types": [],
"lib": ["dom", "es2020"],
"useDefineForClassFields": false,
"moduleResolution": "bundler"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export class DndListDirective<T> implements AfterContentInit, OnDestroy {

/** @hidden */
@HostBinding('class')
private readonly _initialClass = 'fd-dnd-list';
protected readonly _initialClass = 'fd-dnd-list';

/** @hidden */
private _elementsCoordinates: ElementChord[];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@ export abstract class BaseToastAnimatedContainerComponent<P extends BaseAnimated
* The state of the Message Toast animations.
*/
@HostBinding('@state')
private get _animationState(): string {
protected get _animationState(): string {
return this._animationStateSignal();
}
/**
* @hidden
* Whether the animations should be disabled.
*/
@HostBinding('@.disabled')
private _animationsDisabled = false;
protected _animationsDisabled = false;

/** @hidden */
protected _ngZone = inject(NgZone);
Expand All @@ -41,7 +41,7 @@ export abstract class BaseToastAnimatedContainerComponent<P extends BaseAnimated
* Handle end of animations, updating the state of the Message Toast.
*/
@HostListener('@state.done', ['$event'])
private _onAnimationEnd(event: AnimationEvent): void {
protected _onAnimationEnd(event: AnimationEvent): void {
const { fromState, toState } = event;

if ((toState === 'void' && fromState !== 'void') || toState === 'hidden') {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export class DialogContainerComponent

/** The state of the Dialog animations. */
@HostBinding('@state')
private get _animationState(): string {
protected get _animationState(): string {
return this._animationStateSignal();
}

Expand Down
4 changes: 2 additions & 2 deletions libs/core/form/form-control/form-control.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,13 @@ export class FormControlComponent implements CssClassBuilder, OnInit, OnChanges,

/** @hidden */
@HostBinding('attr.aria-label')
private get ariaLabelBinding(): string {
protected get ariaLabelBinding(): string {
return this.ariaLabelAttr || this.ariaLabel || '';
}

/** @hidden */
@HostBinding('attr.aria-labelledby')
private get ariaLabelledByBinding(): string {
protected get ariaLabelledByBinding(): string {
return this.ariaLabelledByAttr || this.ariaLabelledBy || '';
}

Expand Down
2 changes: 1 addition & 1 deletion libs/core/input-group/input-group.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ export class InputGroupComponent implements AfterViewInit, FormItemControl, OnIn

/** @hidden */
@HostListener('focusout', ['$event'])
private _focusOut(event: FocusEvent): void {
protected _focusOut(event: FocusEvent): void {
if (!this.elementRef.nativeElement.contains(event.relatedTarget)) {
this._cva.onTouched();
}
Expand Down
4 changes: 2 additions & 2 deletions libs/core/list/list-item/list-item.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export class ListItemComponent<T = any> extends ListFocusItem<T> implements Afte

/** @hidden */
@HostBinding('attr.role')
private get roleAttr(): string {
protected get roleAttr(): string {
return this.ariaRole || this._role;
}

Expand Down Expand Up @@ -260,7 +260,7 @@ export class ListItemComponent<T = any> extends ListFocusItem<T> implements Afte

/** @hidden */
@HostListener('focus')
private _onFocus(): void {
protected _onFocus(): void {
// Try to find inner focusable link
const tabbableLink = this.elementRef.nativeElement.querySelector('.fd-list__link.fd-list__link--focusable');
tabbableLink?.focus();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export class ListNavigationItemComponent implements AfterContentInit, AfterViewI

/** @hidden */
@HostBinding('attr.aria-expanded')
private get _ariaExpanded(): boolean | null {
protected get _ariaExpanded(): boolean | null {
return this._isExpandable ? this._expanded : null;
}

Expand Down
2 changes: 1 addition & 1 deletion libs/core/list/list.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export class ListComponent implements ListComponentInterface, ListUnreadIndicato

/** @hidden */
@HostBinding('attr.role')
private get _ariaRole(): string {
protected get _ariaRole(): string {
return this.role || this._defaultRole;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export class MessageBoxContainerComponent

/** The state of the Dialog animations. */
@HostBinding('@state')
private get _animationState(): string {
protected get _animationState(): string {
return this._animationStateSignal();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class MultiAnnouncerDirective {

/** @hidden */
@HostListener('keyup', ['$event'])
private _makeSearchTermChangeAnnouncements(event: KeyboardEvent): void {
protected _makeSearchTermChangeAnnouncements(event: KeyboardEvent): void {
if (KeyUtil.isKeyType(event, 'alphabetical') || KeyUtil.isKeyType(event, 'numeric')) {
this._liveAnnouncer.clear();
const count = this.multiAnnouncerOptions?.length;
Expand Down
2 changes: 1 addition & 1 deletion libs/core/multi-input/multi-input.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ export class MultiInputComponent<ItemType = any, ValueType = any>

/** @hidden */
@HostListener('focusout', ['$event'])
private _focusOut(event: FocusEvent): void {
protected _focusOut(event: FocusEvent): void {
if (!this.elementRef.nativeElement.contains(event.relatedTarget as Node)) {
this.onTouched();
}
Expand Down
12 changes: 6 additions & 6 deletions libs/core/nested-list/nested-item/nested-item.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,27 +80,27 @@ export class NestedItemDirective implements AfterContentInit, NestedItemInterfac

/** @hidden */
@HostBinding('attr.role')
private _role: string;
protected _role: string;

/** @hidden */
@HostBinding('attr.aria-expanded')
private _ariaExpanded: Nullable<boolean> = null;
protected _ariaExpanded: Nullable<boolean> = null;

/** @hidden */
@HostBinding('attr.aria-selected')
private _ariaSelected: Nullable<boolean> = null;
protected _ariaSelected: Nullable<boolean> = null;

/** @hidden */
@HostBinding('attr.aria-disabled')
private _ariaDisabled = false;
protected _ariaDisabled = false;

/** @hidden */
@HostBinding('attr.aria-label')
private _ariaLabel: string;
protected _ariaLabel: string;

/** @hidden */
@HostBinding('attr.aria-hidden')
private _ariaHidden = true;
protected _ariaHidden = true;

/** @hidden */
private _expanded = false;
Expand Down
10 changes: 5 additions & 5 deletions libs/core/nested-list/nested-list/nested-list.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,23 +92,23 @@ export class NestedListDirective implements AfterContentInit, NestedListInterfac

/** @hidden */
@ContentChild(NestedListHeaderDirective)
private _nestedListHeader: NestedListHeaderDirective;
protected _nestedListHeader: NestedListHeaderDirective;

/** @hidden */
@HostBinding('attr.role')
private _role = 'tree';
protected _role = 'tree';

/** @hidden */
@HostBinding('attr.aria-roledescription')
private _ariaRoledescription: Nullable<string> = this.ariaRoledescriptionTree;
protected _ariaRoledescription: Nullable<string> = this.ariaRoledescriptionTree;

/** @hidden */
@HostBinding('attr.aria-haspopup')
private _ariaHaspopup: Nullable<string> = null;
protected _ariaHaspopup: Nullable<string> = null;

/** @hidden */
@HostBinding('attr.tabindex')
private _tabindex = '-1';
protected _tabindex = '-1';

/** @hidden */
private _subscriptions = new Subscription();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export class OverflowLayoutFocusableItemDirective implements OverflowLayoutFocus

/** @hidden */
@HostBinding('attr.tabindex')
private get _tabindex(): number {
protected get _tabindex(): number {
return this.focusable ? 0 : -1;
}

Expand All @@ -44,7 +44,7 @@ export class OverflowLayoutFocusableItemDirective implements OverflowLayoutFocus

/** @hidden */
@HostListener('focus')
private _onFocus(): void {
protected _onFocus(): void {
this._overflowContainer.setFocusedElement(this);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class OverflowLayoutItemContainerDirective {

/** @hidden */
@HostBinding('class')
private readonly _initialClass = 'fd-overflow-layout__item';
protected readonly _initialClass = 'fd-overflow-layout__item';

/** @hidden */
constructor(public elementRef: ElementRef) {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class OverflowLayoutPopoverContentDirective implements OverflowPopoverCon

/** @hidden */
@HostBinding('class')
private readonly _initialClass = 'fd-overflow-layout__popover-container';
protected readonly _initialClass = 'fd-overflow-layout__popover-container';

/** @hidden */
private _keyboardEventsManager: Nullable<FocusKeyManager<OverflowLayoutFocusableItem>>;
Expand Down
3 changes: 2 additions & 1 deletion libs/core/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
"options": {
"jestConfig": "{projectRoot}/jest.config.ts"
"jestConfig": "{projectRoot}/jest.config.ts",
"tsConfig": "libs/core/tsconfig.spec.json"
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions libs/core/schematics/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@
"compilerOptions": {
"allowSyntheticDefaultImports": true,
"baseUrl": ".",
"lib": ["es2020", "dom"],
"declaration": true,
"module": "commonjs",
"moduleResolution": "node",
"moduleResolution": "bundler",
"noEmitOnError": true,
"noFallthroughCasesInSwitch": true,
"noImplicitAny": true,
Expand Down
Loading