-
Notifications
You must be signed in to change notification settings - Fork 54
WIP feat(project-access): add path-mappings for ui5 project type 'component' #3927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WIP feat(project-access): add path-mappings for ui5 project type 'component' #3927
Conversation
|
|
SAP employees are expected to use their SAP-email address for commits related to their work. Our compliance check has detected usage of an email other than a SAP one by a SAP employee. Please update your pull request accordingly. If you thing this is wrong or need any assistance, please contact [email protected]. |
…-access/path-mappings-for-type-component
…-access/path-mappings-for-type-component # Conflicts: # packages/project-access/src/project/ui5-config.ts # packages/ui5-config/src/types/ui5yaml.ts
…-access/path-mappings-for-type-component # Conflicts: # packages/preview-middleware/src/base/config.ts # packages/preview-middleware/templates/flp/cdm.ejs # packages/preview-middleware/templates/flp/sandbox.ejs # packages/preview-middleware/templates/flp/sandbox2.ejs # packages/preview-middleware/test/unit/base/__snapshots__/config.test.ts.snap # packages/preview-middleware/test/unit/base/__snapshots__/flp.test.ts.snap
|



UI5 cli v5 will come with a new UI5 project type
componentfor manifest typeapplication.This type has resource roots
src(instead ofwebapp; will be served at/resources/my/app/id) andtest(instead ofwebapp/test; will be served at/test-resources/my/app/id). Doing so it will be possible to serve more than one app with one server instanceDetails see https://ui5.github.io/cli/v5/updates/migrate-v5
todo
open/ux/preview/client/*for project typecomponent?Multiple apps can run in parallel so one central route might cause conflicts
Maybe we need to use the same mechanism as in fix(preview-middleware): support rta and cpe for CAP node w/o mockserver #3842 to hand over the
sandboxPathPrefixto thepreview-middleware-client.or is the UI5 resourceroots mapping enough, e.g.
{"open.ux.preview.client":"/resources/com/sap/cap/fe/ts/sample/preview/client"}Follow-up
fiori-tools-previewandfiori-tools-proxymiddleware after consumption of this changeTest setup
use node
22.22.0adjust ui5 yaml file
specVersion: '5.0'adjust
package.jsondevDependency"@ui5/cli": "^5.0.0-alpha.2"-o /test-resources/app/id/from/manifest/flp.htmlTests
Two apps with UI5 project type 'component' and one app with UI5 project type 'application' served in parallel by one ui5 cli server instance, e.g.
componentapp 1)componentapp 2)applicationapp)Apps can have path mappings defined in the ui5 yaml file
Endpoints that need to be tested:
flp.pathflp.initenhancedHomePage: trueflp.appsflp.pathflp.pathflp.initenhancedHomePage: trueflp.appseditors.rtaeditors.cardGeneratoreditors.cardGenerator.pathpathfor at least oneframeworkinitfor at least oneframeworkpatternfor at least oneframeworkcds-plugin-ui5@sap-ux/ui5-middleware-fe-mockservernpx --yes @sap-ux/create@latest add html)