Skip to content

Conversation

@heimwege
Copy link
Contributor

@heimwege heimwege commented Dec 18, 2025

Integration tests are ok with the changes: https://github.com/SAP/open-ux-tools/actions/runs/20368921976

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2025

🦋 Changeset detected

Latest commit: ac08f0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 68 packages
Name Type
@sap-ux/cds-odata-annotation-converter Patch
@sap-ux-private/preview-middleware-client Patch
@sap-ux/control-property-editor Patch
@sap-ux/serve-static-middleware Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/ui5-application-writer Patch
@sap-ux/cds-annotation-parser Patch
@sap-ux/fiori-docs-embeddings Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/odata-annotation-core Patch
@sap-ux/annotation-generator Patch
@sap-ux/fiori-annotation-api Patch
@sap-ux/jest-environment-ui5 Patch
@sap-ux/environment-check Patch
@sap-ux/axios-extension Patch
@sap-ux/inquirer-common Patch
@sap-ux/deploy-tooling Patch
@sap-ux/project-access Patch
@sap-ux/fe-fpm-writer Patch
@sap-ux/launch-config Patch
@sap-ux/ui-components Patch
@sap-ux/adp-tooling Patch
@sap-ux/deploy-config-sub-generator Patch
@sap-ux/fiori-app-sub-generator Patch
@sap-ux/repo-app-import-sub-generator Patch
@sap-ux/ui-service-inquirer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/ui5-test-writer Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/fiori-mcp-server Patch
@sap-ux/xml-odata-annotation-converter Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/app-config-writer Patch
@sap-ux/backend-proxy-middleware Patch
@sap-ux/deploy-config-generator-shared Patch
@sap-ux/fiori-generator-shared Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/generator-adp Patch
@sap-ux/odata-service-writer Patch
@sap-ux/preview-middleware Patch
@sap-ux/system-access Patch
@sap-ux/ui-service-sub-generator Patch
@sap-ux/odata-cli Patch
@sap-ux/cf-deploy-config-inquirer Patch
@sap-ux/cf-deploy-config-sub-generator Patch
@sap-ux/create Patch
@sap-ux/flp-config-sub-generator Patch
@sap-ux/ui-prompting Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-inquirer Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/backend-proxy-middleware-cf Patch
@sap-ux/cap-config-writer Patch
@sap-ux/cf-deploy-config-writer Patch
@sap-ux/mockserver-config-writer Patch
@sap-ux/project-input-validator Patch
@sap-ux/project-integrity Patch
@sap-ux/telemetry Patch
@sap-ux/ui5-library-reference-sub-generator Patch
@sap-ux/ui5-library-reference-writer Patch
@sap-ux/ui5-library-writer Patch
@sap-ux-private/ui-prompting-examples Patch
@sap-ux-private/adaptation-editor-tests Patch
@sap-ux/fe-fpm-cli Patch
@sap-ux/ui5-library-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@heimwege heimwege marked this pull request as ready for review December 18, 2025 22:48
@heimwege heimwege requested review from a team as code owners December 18, 2025 22:48
@heimwege heimwege requested review from a team as code owners December 19, 2025 10:23
@heimwege heimwege requested review from a team as code owners December 19, 2025 10:59
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changesets are good.
Changes are good.

@sap-email-compliance
Copy link

SAP employees are expected to use their SAP-email address for commits related to their work. Our compliance check has detected usage of an email other than a SAP one by a SAP employee. Please update your pull request accordingly.

If you think this is wrong or need any assistance, please contact ospo@sap.com.

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heimwege
Code changes lg.
changeset ✅

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

@heimwege heimwege merged commit e111d0d into main Jan 9, 2026
16 of 17 checks passed
@heimwege heimwege deleted the fix/sonar-issues-part-2 branch January 9, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants