Skip to content

Conversation

@mikicvi-SAP
Copy link
Contributor

@mikicvi-SAP mikicvi-SAP commented Dec 29, 2025

#3959

  • Improves detection of local cap roots on the CLI for CAP project source
  • support autocomplete for CAP project selection on CLI

@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2025

🦋 Changeset detected

Latest commit: 0238e5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 50 packages
Name Type
@sap-ux/odata-service-inquirer Minor
@sap-ux/fiori-app-sub-generator Patch
@sap-ux/project-access Patch
@sap-ux/deploy-config-sub-generator Patch
@sap-ux/repo-app-import-sub-generator Patch
@sap-ux/ui-service-inquirer Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/adp-tooling Patch
@sap-ux/annotation-generator Patch
@sap-ux/app-config-writer Patch
@sap-ux/backend-proxy-middleware-cf Patch
@sap-ux/cap-config-writer Patch
@sap-ux/cf-deploy-config-sub-generator Patch
@sap-ux/cf-deploy-config-writer Patch
@sap-ux/create Patch
@sap-ux/environment-check Patch
@sap-ux/fe-fpm-writer Patch
@sap-ux/fiori-annotation-api Patch
@sap-ux/fiori-generator-shared Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/flp-config-sub-generator Patch
@sap-ux/generator-adp Patch
@sap-ux/launch-config Patch
@sap-ux/mockserver-config-writer Patch
@sap-ux/odata-service-writer Patch
@sap-ux/preview-middleware Patch
@sap-ux/project-input-validator Patch
@sap-ux/project-integrity Patch
@sap-ux/telemetry Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/ui5-library-reference-sub-generator Patch
@sap-ux/ui5-library-reference-writer Patch
@sap-ux/ui5-library-writer Patch
@sap-ux/ui5-test-writer Patch
@sap-ux-private/adaptation-editor-tests Patch
@sap-ux/ui-service-sub-generator Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/fe-fpm-cli Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/deploy-config-generator-shared Patch
@sap-ux/inquirer-common Patch
@sap-ux/ui5-library-sub-generator Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/cf-deploy-config-inquirer Patch
@sap-ux/deploy-tooling Patch
@sap-ux/ui5-library-inquirer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sap-email-compliance
Copy link

SAP employees are expected to use their SAP-email address for commits related to their work. Our compliance check has detected usage of an email other than a SAP one by a SAP employee. Please update your pull request accordingly.

If you think this is wrong or need any assistance, please contact ospo@sap.com.

@mikicvi-SAP mikicvi-SAP marked this pull request as ready for review December 31, 2025 15:39
@mikicvi-SAP mikicvi-SAP requested review from a team as code owners December 31, 2025 15:39
@mikicvi-SAP mikicvi-SAP self-assigned this Dec 31, 2025
Copy link
Contributor

@lfindlaysap lfindlaysap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikicvi-SAP, small tweak.

lfindlaysap
lfindlaysap previously approved these changes Jan 2, 2026
lfindlaysap
lfindlaysap previously approved these changes Jan 2, 2026
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply relative path handling to all folder prompts otherwise we are introducing an inconsistency. I would suggest a seperate PR for that work

…election on CLI, search 2 levels up w/o traversal for cap root on CLI, tests
@mikicvi-SAP mikicvi-SAP requested a review from a team as a code owner January 9, 2026 12:05
@mikicvi-SAP mikicvi-SAP changed the title tbi(odata-service-inq): implement automatic detection of local CAP roots, relative paths tbi(odata-service-inq): improve detection of local CAP roots on CLI Jan 9, 2026
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikicvi-SAP

  • All comments addressed, code is clear
  • Tests added to cover

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikicvi-SAP Thanks for the updates.
Changes lg. 1 minor observation.
Changeset 👍

@sonarqubecloud
Copy link

@mikicvi-SAP mikicvi-SAP merged commit f13d1c2 into main Jan 12, 2026
16 of 17 checks passed
@mikicvi-SAP mikicvi-SAP deleted the tbi/3959/cap-root-detection-cli branch January 12, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants