-
Notifications
You must be signed in to change notification settings - Fork 54
tbi(odata-service-inq): improve detection of local CAP roots on CLI #3960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…th validation for relative paths
🦋 Changeset detectedLatest commit: 0238e5f The changes in this PR will be included in the next version bump. This PR includes changesets to release 50 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
SAP employees are expected to use their SAP-email address for commits related to their work. Our compliance check has detected usage of an email other than a SAP one by a SAP employee. Please update your pull request accordingly. If you think this is wrong or need any assistance, please contact ospo@sap.com. |
lfindlaysap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikicvi-SAP, small tweak.
packages/odata-service-inquirer/src/translations/odata-service-inquirer.i18n.json
Outdated
Show resolved
Hide resolved
packages/odata-service-inquirer/src/prompts/datasources/cap-project/cap-helpers.ts
Outdated
Show resolved
Hide resolved
packages/odata-service-inquirer/src/prompts/datasources/cap-project/cap-helpers.ts
Outdated
Show resolved
Hide resolved
packages/odata-service-inquirer/src/prompts/datasources/cap-project/cap-helpers.ts
Show resolved
Hide resolved
packages/odata-service-inquirer/src/prompts/datasources/cap-project/cap-helpers.ts
Outdated
Show resolved
Hide resolved
packages/odata-service-inquirer/src/prompts/datasources/cap-project/cap-helpers.ts
Outdated
Show resolved
Hide resolved
packages/odata-service-inquirer/src/prompts/datasources/cap-project/cap-helpers.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply relative path handling to all folder prompts otherwise we are introducing an inconsistency. I would suggest a seperate PR for that work
…election on CLI, search 2 levels up w/o traversal for cap root on CLI, tests
IainSAP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mikicvi-SAP
- All comments addressed, code is clear
- Tests added to cover
devinea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikicvi-SAP Thanks for the updates.
Changes lg. 1 minor observation.
Changeset 👍
packages/odata-service-inquirer/src/prompts/datasources/cap-project/cap-helpers.ts
Show resolved
Hide resolved
|



#3959