-
Notifications
You must be signed in to change notification settings - Fork 54
feat(generator-adp): Developer taking over Key-User changes #3967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: ded968e The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
SAP employees are expected to use their SAP-email address for commits related to their work. Our compliance check has detected usage of an email other than a SAP one by a SAP employee. Please update your pull request accordingly. If you think this is wrong or need any assistance, please contact ospo@sap.com. |
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
lfindlaysap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikmace, thanks for the screenshots. Here are my suggestions.
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
testojs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove
IainSAP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving for @sap-ux/axios-extension
e89b8ae
|
Hello @lfindlaysap, I've made some changes to the texts, can you check again? This is the commit: 45a4f11. I can send you pictures if needed. |
lfindlaysap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikmace, here are my suggestions. Thanks for the screenshots :)
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
|
testojs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove



Feat for #3964.
@sap-ux/axios-extensionLREP with two additional calls forflex version,list adaptationsandkey-user changesfor given adaptation.