Skip to content

Conversation

@nikmace
Copy link
Contributor

@nikmace nikmace commented Jan 5, 2026

Feat for #3964.

  • Adds a new Key-User page after the Project Attributes page.
  • Enhances @sap-ux/axios-extension LREP with two additional calls for flex version, list adaptations and key-user changes for given adaptation.

@nikmace nikmace self-assigned this Jan 5, 2026
@nikmace nikmace requested review from a team as code owners January 5, 2026 16:18
@nikmace nikmace added axios-extension @sap-ux/axios-extension adp-tooling generator-adp @sap-ux/generator-adp labels Jan 5, 2026
@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2026

🦋 Changeset detected

Latest commit: ded968e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@sap-ux/generator-adp Minor
@sap-ux/axios-extension Patch
@sap-ux/adp-tooling Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/app-config-writer Patch
@sap-ux/backend-proxy-middleware Patch
@sap-ux/deploy-tooling Patch
@sap-ux/environment-check Patch
@sap-ux/fiori-app-sub-generator Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/repo-app-import-sub-generator Patch
@sap-ux/system-access Patch
@sap-ux/ui-service-inquirer Patch
@sap-ux/ui-service-sub-generator Patch
@sap-ux/odata-cli Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/backend-proxy-middleware-cf Patch
@sap-ux/create Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/deploy-config-sub-generator Patch
@sap-ux/flp-config-sub-generator Patch
@sap-ux/abap-deploy-config-writer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sap-email-compliance
Copy link

SAP employees are expected to use their SAP-email address for commits related to their work. Our compliance check has detected usage of an email other than a SAP one by a SAP employee. Please update your pull request accordingly.

If you think this is wrong or need any assistance, please contact ospo@sap.com.

Copy link
Contributor

@lfindlaysap lfindlaysap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikmace, thanks for the screenshots. Here are my suggestions.

@nikmace nikmace requested a review from lfindlaysap January 7, 2026 13:52
lfindlaysap
lfindlaysap previously approved these changes Jan 16, 2026
testojs
testojs previously approved these changes Jan 16, 2026
Copy link
Contributor

@testojs testojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove

IainSAP
IainSAP previously approved these changes Jan 16, 2026
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving for @sap-ux/axios-extension

@nikmace nikmace dismissed stale reviews from IainSAP, testojs, and lfindlaysap via e89b8ae January 19, 2026 07:56
@lfindlaysap lfindlaysap self-requested a review January 19, 2026 10:30
lfindlaysap
lfindlaysap previously approved these changes Jan 19, 2026
@nikmace
Copy link
Contributor Author

nikmace commented Jan 22, 2026

Hello @lfindlaysap, I've made some changes to the texts, can you check again? This is the commit: 45a4f11. I can send you pictures if needed.

@nikmace nikmace requested a review from lfindlaysap January 22, 2026 08:50
Copy link
Contributor

@lfindlaysap lfindlaysap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikmace, here are my suggestions. Thanks for the screenshots :)

lfindlaysap
lfindlaysap previously approved these changes Jan 22, 2026
@nikmace nikmace requested a review from IainSAP January 22, 2026 10:47
@sonarqubecloud
Copy link

@nikmace nikmace requested a review from lfindlaysap January 22, 2026 14:16
Copy link
Contributor

@testojs testojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adp-tooling axios-extension @sap-ux/axios-extension generator-adp @sap-ux/generator-adp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants