feat(generator-adp): Developer taking over Key-User changes#3967
Merged
feat(generator-adp): Developer taking over Key-User changes#3967
Conversation
nikmace
added
axios-extension
🦋 Changeset detectedLatest commit: 1a8b6a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
SAP employees are expected to use their SAP-email address for commits related to their work. Our compliance check has detected usage of an email other than a SAP one by a SAP employee. Please update your pull request accordingly. If you think this is wrong or need any assistance, please contact ospo@sap.com. |
lfindlaysap
reviewed
Jan 6, 2026
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
lfindlaysap
requested changes
Jan 6, 2026
Contributor
lfindlaysap
left a comment
lfindlaysap
left a comment
There was a problem hiding this comment.
@nikmace, thanks for the screenshots. Here are my suggestions.
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
nikmace
dismissed stale reviews from IainSAP, testojs, and lfindlaysap
via
e89b8ae
lfindlaysap
previously approved these changes
Jan 19, 2026
Contributor
Author
|
Hello @lfindlaysap, I've made some changes to the texts, can you check again? This is the commit: 45a4f11. I can send you pictures if needed. |
lfindlaysap
requested changes
Jan 22, 2026
Contributor
lfindlaysap
left a comment
lfindlaysap
left a comment
There was a problem hiding this comment.
@nikmace, here are my suggestions. Thanks for the screenshots :)
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
lfindlaysap
previously approved these changes
Jan 22, 2026
lfindlaysap
approved these changes
Jan 22, 2026
|
IainSAP
approved these changes
Jan 26, 2026
Contributor
IainSAP
left a comment
IainSAP
left a comment
There was a problem hiding this comment.
Re-approving for axios-extension.
devinea
added a commit
that referenced
this pull request
Jan 26, 2026
…nds_to_index * origin/main: chore: apply latest changesets feat(generator-adp): Developer taking over Key-User changes (#3967)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feat for #3964.
@sap-ux/axios-extensionLREP with two additional calls forflex version,list adaptationsandkey-user changesfor given adaptation.