feat: Adjust FLP configuration wizard for CF scenario#4455
Open
feat: Adjust FLP configuration wizard for CF scenario#4455
Conversation
nikmace
added
create
🦋 Changeset detectedLatest commit: 75c1312 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lfindlaysap
requested changes
Mar 24, 2026
packages/adp-flp-config-sub-generator/src/translations/adp-flp-config-sub-generator.i18n.json
Outdated
Show resolved
Hide resolved
packages/adp-flp-config-sub-generator/src/translations/adp-flp-config-sub-generator.i18n.json
Outdated
Show resolved
Hide resolved
…/SAP/open-ux-tools into feat/4452/adjust-flp-gen-and-cli
lfindlaysap
requested changes
Mar 25, 2026
…/SAP/open-ux-tools into feat/4452/adjust-flp-gen-and-cli
lfindlaysap
requested changes
Mar 26, 2026
packages/adp-flp-config-sub-generator/src/translations/adp-flp-config-sub-generator.i18n.json
Outdated
Show resolved
Hide resolved
lfindlaysap
previously approved these changes
Mar 26, 2026
avasilev-sap
requested changes
Mar 27, 2026
Contributor
avasilev-sap
left a comment
avasilev-sap
left a comment
There was a problem hiding this comment.
Overall change looks good, just a small comments about nested if statements and url param encoding.
lfindlaysap
approved these changes
Mar 27, 2026
heimwege
reviewed
Mar 30, 2026
| ): Promise<ManifestNamespace.Inbound | undefined> { | ||
| const cfConfig = loadCfConfig(logger); | ||
| if (!cfConfig?.token) { | ||
| throw new Error('CF login required. Please run "cf login" and try again.'); |
Contributor
There was a problem hiding this comment.
@lfindlaysap you are fine with using CF? I'm suprised.
heimwege
approved these changes
Mar 30, 2026
Contributor
heimwege
left a comment
heimwege
left a comment
There was a problem hiding this comment.
- Checked
createpackage - did NOT test manually
- changeset ok
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feat for #4452.
FDCAPI to retrieve inbounds.navigation-configCLI command to support CF scenario.standaloneoras sub-generator.