Skip to content

feat(backend-proxy-middleware): add property for additional url params#4484

Merged
heimwege merged 5 commits intomainfrom
feat/backend-proxy-middleware/add-url-params
Mar 30, 2026
Merged

feat(backend-proxy-middleware): add property for additional url params#4484
heimwege merged 5 commits intomainfrom
feat/backend-proxy-middleware/add-url-params

Conversation

@heimwege
Copy link
Copy Markdown
Contributor

@heimwege heimwege commented Mar 27, 2026

Summary

Problem

Developers working with backends that require additional query parameters (e.g. saml2=disabled to bypass SAML for Basic Auth flows) had no supported mechanism to append them. As a workaround, they injected parameters via the client property (e.g. client: "100&saml2=disabled"), which is fragile and undocumented.

Solution

New params property

  - name: backend-proxy-middleware
    afterMiddleware: compression
    configuration:
      backend:
        path: /sap
        url: https://my.backend.example:1234
        client: '100'
        params:
          saml2: disabled

The property is named params for consistency with UrlAbapTarget.params in @sap-ux/system-access, which serves the same purpose in the deploy task.

Client validation warning

When client contains a value that is not a 1–3 digit number, a warning is logged pointing to params as the correct
alternative. The existing workaround continues to function to avoid breaking existing projects.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 27, 2026

🦋 Changeset detected

Latest commit: 0dd220d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/backend-proxy-middleware Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@heimwege heimwege added the backend-proxy-middleware @sap-ux/backend-proxy-middleware label Mar 27, 2026
@heimwege heimwege requested a review from longieirl March 27, 2026 21:30
@heimwege heimwege changed the title feat(packend-proxy-middleware): add property for additional url params feat(backend-proxy-middleware): add property for additional url params Mar 27, 2026
@heimwege heimwege requested a review from ytpo-lyne March 27, 2026 22:00
@heimwege heimwege marked this pull request as ready for review March 27, 2026 22:00
@heimwege heimwege requested a review from a team as a code owner March 27, 2026 22:00
Copy link
Copy Markdown
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset is good.
Tests are good.
Change looks good.

Copy link
Copy Markdown
Contributor

@ytpo-lyne ytpo-lyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • changes to add url params look good
  • changeset present
  • coverage given
  • tested manually, no issues found

Approving.

@sonarqubecloud
Copy link
Copy Markdown

@heimwege heimwege merged commit fe8e66f into main Mar 30, 2026
21 of 25 checks passed
@heimwege heimwege deleted the feat/backend-proxy-middleware/add-url-params branch March 30, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend-proxy-middleware @sap-ux/backend-proxy-middleware

Projects

None yet

Development

Successfully merging this pull request may close these issues.

client property in ui5.yaml can be misused to inject query parameters into backend URLs

3 participants