feat(backend-proxy-middleware): add property for additional url params#4484
Merged
feat(backend-proxy-middleware): add property for additional url params#4484
Conversation
🦋 Changeset detectedLatest commit: 0dd220d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
longieirl
approved these changes
Mar 30, 2026
Contributor
longieirl
left a comment
There was a problem hiding this comment.
Changeset is good.
Tests are good.
Change looks good.
ytpo-lyne
approved these changes
Mar 30, 2026
Contributor
ytpo-lyne
left a comment
There was a problem hiding this comment.
- changes to add url params look good
- changeset present
- coverage given
- tested manually, no issues found
Approving.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
"100&saml2=disabled"), guiding developers to use params insteadProblem
Developers working with backends that require additional query parameters (e.g. saml2=disabled to bypass SAML for Basic Auth flows) had no supported mechanism to append them. As a workaround, they injected parameters via the client property (e.g. client: "100&saml2=disabled"), which is fragile and undocumented.
Solution
New params property
The property is named params for consistency with
UrlAbapTarget.paramsin@sap-ux/system-access, which serves the same purpose in the deploy task.Client validation warning
When client contains a value that is not a 1–3 digit number, a warning is logged pointing to params as the correct
alternative. The existing workaround continues to function to avoid breaking existing projects.