Conversation
…shes when joining paths
🦋 Changeset detectedLatest commit: a0fc666 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 tasks
Singham-24
approved these changes
Mar 30, 2026
Contributor
Singham-24
left a comment
Singham-24
left a comment
There was a problem hiding this comment.
Changeset OK
Did not test manually
coverage ok
Sharmavksh
approved these changes
Mar 30, 2026
Contributor
Sharmavksh
left a comment
Sharmavksh
left a comment
There was a problem hiding this comment.
=> Changes are straightforward.
=> Test cases has been added for the latest changes.
=> Changeset has been added.
Looks good to me.
ytpo-lyne
approved these changes
Mar 31, 2026
Contributor
ytpo-lyne
left a comment
ytpo-lyne
left a comment
There was a problem hiding this comment.
- changes to sanitize cards generator manifest URL look good
- changeset present
- full coverage
- did not test manually
Approving.
|
devinea
added a commit
that referenced
this pull request
Mar 31, 2026
* origin/main: (30 commits) chore: apply latest changesets fix: adjust min height for buttons after latest fount ui update (#4499) fix: int test (#4473) chore: apply latest changesets fix: add legacy eslint config for recommended-for-s4hana (#4494) chore: apply latest changesets fix(sap-systems-ext): correct system name validator (#4493) chore: apply latest changesets feat(ui5-test-writer): Generate OPA5 tests for Object Page sections & subsections (#4437) chore: apply latest changesets feat(eslint-plugin-fiori-tools): add DataFieldForIntentBasedNavigation XML annotation rule (#4261) chore: apply latest changesets Add line-height to UITranslationInput text (#4497) chore: apply latest changesets error, warning, info boxes have rounded corners (#4492) chore: apply latest changesets fix(preview-middleware): sanitize cards generator manifest URL to avoid issues with double slashes when joining paths (#4485) chore: apply latest changesets feat(backend-proxy-middleware): add property for additional url params (#4484) chore(preview-middleware): update snapshots (#4495) ...
devinea
added a commit
that referenced
this pull request
Mar 31, 2026
…types_and_apis * origin/main: (30 commits) chore: apply latest changesets fix: adjust min height for buttons after latest fount ui update (#4499) fix: int test (#4473) chore: apply latest changesets fix: add legacy eslint config for recommended-for-s4hana (#4494) chore: apply latest changesets fix(sap-systems-ext): correct system name validator (#4493) chore: apply latest changesets feat(ui5-test-writer): Generate OPA5 tests for Object Page sections & subsections (#4437) chore: apply latest changesets feat(eslint-plugin-fiori-tools): add DataFieldForIntentBasedNavigation XML annotation rule (#4261) chore: apply latest changesets Add line-height to UITranslationInput text (#4497) chore: apply latest changesets error, warning, info boxes have rounded corners (#4492) chore: apply latest changesets fix(preview-middleware): sanitize cards generator manifest URL to avoid issues with double slashes when joining paths (#4485) chore: apply latest changesets feat(backend-proxy-middleware): add property for additional url params (#4484) chore(preview-middleware): update snapshots (#4495) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4430
fixes issue with card generator creating manifests with wrong data request url (
...//$batch)But actually this should be fixed by the card generator component by collapsing
//to/before writing it to the request url property.