fix: make eslint recommended as warning for recommended-for-s4hana#4494
fix: make eslint recommended as warning for recommended-for-s4hana#4494marufrasully wants to merge 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 0a7e4a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
The test file (test/eslint-plugin.test.ts) only tests plugin.configs.recommended. There are no tests for recommended-for-s4hana, which is the primary target of this change. The S4HANA-specific behavior — ESLint recommended rules becoming warn instead of error, and mockserver.js being ignored — is entirely untested. |
There was a problem hiding this comment.
QA Report
Tested eslint-plugin-fiori-tools using a Fiori S/4HANA project with recommended-for-s4hana config.
The following scenarios covered:
- Config loads, ESLint server starts without errors ;
- webapp/localService/mockserver.js produces no lint output (ignored)
no-unused-vars(ESLint recommended rule) shows as warning in S/4HANA config;- SAP-specific rules (e.g. sap-no-localstorage) still show as error ;
- Custom files in webapp/localService/ (non-mockserver) are still linted ;
All scenarios passed ✅


This PR
mockserver.jsfile specifically