Skip to content

fix: make eslint recommended as warning for recommended-for-s4hana#4494

Open
marufrasully wants to merge 2 commits intomainfrom
fix/js-recommended
Open

fix: make eslint recommended as warning for recommended-for-s4hana#4494
marufrasully wants to merge 2 commits intomainfrom
fix/js-recommended

Conversation

@marufrasully
Copy link
Copy Markdown
Contributor

This PR

  • make eslint recommended as warning for recommended-for-s4hana
  • ignore mockserver.js file specifically

@marufrasully marufrasully requested a review from a team as a code owner March 30, 2026 14:10
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 30, 2026

🦋 Changeset detected

Latest commit: 0a7e4a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/eslint-plugin-fiori-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@heimwege
Copy link
Copy Markdown
Contributor

The test file (test/eslint-plugin.test.ts) only tests plugin.configs.recommended. There are no tests for recommended-for-s4hana, which is the primary target of this change. The S4HANA-specific behavior — ESLint recommended rules becoming warn instead of error, and mockserver.js being ignored — is entirely untested.

Copy link
Copy Markdown
Member

@igorsVoronins igorsVoronins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Report
Tested eslint-plugin-fiori-tools using a Fiori S/4HANA project with recommended-for-s4hana config.
The following scenarios covered:

  • Config loads, ESLint server starts without errors ;
  • webapp/localService/mockserver.js produces no lint output (ignored)
  • no-unused-vars (ESLint recommended rule) shows as warning in S/4HANA config;
  • SAP-specific rules (e.g. sap-no-localstorage) still show as error ;
  • Custom files in webapp/localService/ (non-mockserver) are still linted ;

All scenarios passed ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants