Open
Conversation
🦋 Changeset detectedLatest commit: 7b40c49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 68 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix high and medium severity SONAR issues (https://sonarcloud.io/project/issues?impactSeverities=HIGH%2CMEDIUM&issueStatuses=OPEN%2CCONFIRMED&id=SAP_open-ux-tools)
Skipped Issues:
UI component issues (need visual/CSS work):
<div role="button"> → <button>requires CSS button resets (border, background, padding) that .theme-child doesn't currently have.role="gridcell"divs live inside FluentUI's DetailsList which is a div-based table, so replacing with would produce invalid HTML.<span onClick> → <button>would break 12 tests that explicitly query .ms-DetailsRow-cell span.<div onBlur>needs the onBlur handler for focus management and has no suitable native element replacement.<div onKeyDown onClick>forwards parent-provided handlers and restructuring would change the component's public API.<div role="group">with<fieldset>requires converting UILabel to a , which is a non-trivial refactor.<a href="#"> → <button>would visually break the link because .textLink only sets color and doesn't reset button defaults.Ignored tests (S1607):