Skip to content

feat(fiori-mcp-server): Skill productization - #5175

Open
IvoSG wants to merge 4 commits into
feat/adp-mcp-rta-workflowfrom
feat/skill-and-knowledge-base
Open

IvoSG wants to merge 4 commits into
feat/adp-mcp-rta-workflowfrom
feat/skill-and-knowledge-base

Conversation

@IvoSG

@IvoSG IvoSG commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Title: Productize SAP Fiori ADP Controller Extension Skill

Description

Productizes the SAP Fiori ADP controller extension skill by renaming and enriching the skill metadata, modularizing long guidance into reference documents, and tightening workflow instructions for safer adaptation project changes.

Key updates:

  • Renamed the skill to sap-fiori-adp-controller-extension with clearer trigger guidance and metadata.
  • Split large sections from SKILL.md into dedicated references:
    • actions-reference.md
    • hitl-gating.md
    • example-session.md
  • Updated workflow guidance for navigation, action selection, payload preparation, cleanup, and error handling.
  • Standardized MCP tool references to public tool names.
  • Improved Chromium fallback and editor-server shutdown instructions across platforms.
  • Enhanced ADP controller extension knowledge base rules around:
    • stable IDs, with a Dialog exception
    • controller extension naming and reuse
    • variant-id-based namespaces
    • fragment handler resolution
    • on-demand OData property fetching
    • numeric threshold handling

Type of change

  • Bug (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a new feature)
  • Breaking change (Bug or New feature that would cause existing functionality/consumers to not work as expected)
  • Non-Breaking chores (Changes to tools, libraries, build process, documentation, etc)
  • None of the above (Reviewers might ask for more clarification)

How have you tested?

Documentation and prompt-only changes. Reviewed the updated skill flow, reference links, and knowledge base guidance for consistency and completeness.

Checklist:

  • The code conforms to the general development principles

  • Supplied as many details as possible on this change

  • The code is easy to read and maintainable by others

  • Corresponding changes to the documentation has been done

  • Already existing and new unit tests pass locally

  • I have reviewed and addressed all Hyperspace bot findings (or explicitly explained dismissals)

  • I have done an Agentic review

  • 🔄 Regenerate and Update Summary

PR Bot Information

Version: 1.31.30

  • Correlation ID: 5ef40d40-adbe-11f1-9a1e-0f37fa369d08
  • Event Trigger: pull_request.opened
  • Output Template: Repository PR Template
  • LLM: gpt-5.5
  • Summary Prompt: Default Prompt
  • File Content Strategy: Full file content

@IvoSG IvoSG self-assigned this Sep 11, 2026
@IvoSG
IvoSG requested review from a team as code owners September 11, 2026 08:54
@IvoSG IvoSG added feature New feature or request fiori-mcp @sap-ux/fiori-mcp labels Sep 11, 2026
@changeset-bot

changeset-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7b84897

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/fiori-mcp-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hyperspace-pr-bot hyperspace-pr-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple of issues in the split-out documentation where rules became either over-broad or less deterministic than the original skill text. Overall the refactor is straightforward, but please tighten those references so the productized skill keeps the same runtime behavior.

PR Bot Information

Version: 1.31.30

  • Correlation ID: 5ef40d40-adbe-11f1-9a1e-0f37fa369d08
  • Event Trigger: pull_request.opened
  • Agent Instructions:
  • LLM: gpt-5.5
  • File Content Strategy: Full file content

Comment thread packages/fiori-mcp-server/skills/sap-fiori-adp-controller-extension/SKILL.md Outdated
Comment thread packages/fiori-mcp-server/skills/sap-fiori-adp-controller-extension/SKILL.md Outdated
@IvoSG
IvoSG requested a review from nikmace September 11, 2026 12:18

@mmilko01 mmilko01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments

Comment thread .changeset/honest-zoos-kneel.md Outdated
@IvoSG
IvoSG requested a review from mmilko01 September 14, 2026 13:07

@mmilko01 mmilko01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nikmace nikmace left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request fiori-mcp @sap-ux/fiori-mcp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants