Conversation
🦋 Changeset detectedLatest commit: 7b84897 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
I found a couple of issues in the split-out documentation where rules became either over-broad or less deterministic than the original skill text. Overall the refactor is straightforward, but please tighten those references so the productized skill keeps the same runtime behavior.
nikmace
requested changes
Sep 11, 2026
mmilko01
reviewed
Sep 14, 2026
mmilko01
left a comment
Contributor
There was a problem hiding this comment.
Just a few small comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Productize SAP Fiori ADP Controller Extension Skill
Description
Productizes the SAP Fiori ADP controller extension skill by renaming and enriching the skill metadata, modularizing long guidance into reference documents, and tightening workflow instructions for safer adaptation project changes.
Key updates:
sap-fiori-adp-controller-extensionwith clearer trigger guidance and metadata.SKILL.mdinto dedicated references:actions-reference.mdhitl-gating.mdexample-session.mdType of change
How have you tested?
Documentation and prompt-only changes. Reviewed the updated skill flow, reference links, and knowledge base guidance for consistency and completeness.
Checklist:
The code conforms to the general development principles
Supplied as many details as possible on this change
The code is easy to read and maintainable by others
Corresponding changes to the documentation has been done
Already existing and new unit tests pass locally
I have reviewed and addressed all Hyperspace bot findings (or explicitly explained dismissals)
I have done an Agentic review
🔄 Regenerate and Update Summary
PR Bot Information
Version:
1.31.305ef40d40-adbe-11f1-9a1e-0f37fa369d08pull_request.openedgpt-5.5