Skip to content

Feat(eslint-plugin-fiori-tools): update warning messages with code indicators - #5182

Draft
AlinaGovoruhina wants to merge 2 commits into
mainfrom
feat/eslint-fiori/update-messages-with-code-indicators
Draft

AlinaGovoruhina wants to merge 2 commits into
mainfrom
feat/eslint-fiori/update-messages-with-code-indicators

Conversation

@AlinaGovoruhina

@AlinaGovoruhina AlinaGovoruhina commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Update Fiori ESLint diagnostics to highlight code identifiers

Description

Improves diagnostic messages across eslint-plugin-fiori-tools by formatting rule-related properties, values, and annotation names as inline code for better readability in warnings/errors.

Key updates:

  • Standardized message formatting for multiple Fiori ESLint rules using backticks around code-like identifiers and values.
  • Enhanced sap-copy-to-clipboard diagnostics to report the exact property name (copy or disableCopyToClipboard) instead of a generic “Copy To Clipboard” label.
  • Extended the CopyToClipboard diagnostic data model with a property field.
  • Updated affected unit test expectations to match the revised diagnostic text.

Type of change

  • Bug (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a new feature)
  • Breaking change (Bug or New feature that would cause existing functionality/consumers to not work as expected)
  • Non-Breaking chores (Changes to tools, libraries, build process, documentation, etc)
  • None of the above (Reviewers might ask for more clarification)

How have you tested?

Updated the relevant rule unit test expectations for the changed diagnostic messages, including:

  • copy to clipboard
  • creation mode for table
  • intent-based navigation annotations
  • state preservation mode
  • table personalization
  • width including column header

Checklist:

  • The code conforms to the general development principles

  • Supplied as many details as possible on this change

  • The code is easy to read and maintainable by others

  • Corresponding changes to the documentation has been done

  • Already existing and new unit tests pass locally

  • I have reviewed and addressed all Hyperspace bot findings (or explicitly explained dismissals)

  • I have done an Agentic review

  • 🔄 Regenerate and Update Summary

PR Bot Information

Version: 1.31.30

  • Output Template: Repository PR Template
  • Event Trigger: pull_request.opened
  • File Content Strategy: Full file content
  • Summary Prompt: Default Prompt
  • LLM: gpt-5.5
  • Correlation ID: da2f0110-b028-11f1-8977-98019e102bfd

@changeset-bot

changeset-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d5fd1bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant