Feat(eslint-plugin-fiori-tools): update warning messages with code indicators - #5182
Draft
AlinaGovoruhina wants to merge 2 commits into
Draft
AlinaGovoruhina wants to merge 2 commits into
AlinaGovoruhina wants to merge 2 commits into
Conversation
|
AlinaGovoruhina
had a problem deploying
to
ci-secrets
September 14, 2026 10:41 — with
GitHub Actions
Error
AlinaGovoruhina
had a problem deploying
to
ci-secrets
September 14, 2026 10:41 — with
GitHub Actions
Error
AlinaGovoruhina
had a problem deploying
to
ci-secrets
September 14, 2026 10:41 — with
GitHub Actions
Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Update Fiori ESLint diagnostics to highlight code identifiers
Description
Improves diagnostic messages across
eslint-plugin-fiori-toolsby formatting rule-related properties, values, and annotation names as inline code for better readability in warnings/errors.Key updates:
sap-copy-to-clipboarddiagnostics to report the exact property name (copyordisableCopyToClipboard) instead of a generic “Copy To Clipboard” label.CopyToClipboarddiagnostic data model with apropertyfield.Type of change
How have you tested?
Updated the relevant rule unit test expectations for the changed diagnostic messages, including:
Checklist:
The code conforms to the general development principles
Supplied as many details as possible on this change
The code is easy to read and maintainable by others
Corresponding changes to the documentation has been done
Already existing and new unit tests pass locally
I have reviewed and addressed all Hyperspace bot findings (or explicitly explained dismissals)
I have done an Agentic review
🔄 Regenerate and Update Summary
PR Bot Information
Version:
1.31.30pull_request.openedgpt-5.5da2f0110-b028-11f1-8977-98019e102bfd