Merged
Conversation
For every test where we do not check for __taintreport events, this unifies the usage of the mochitest approaches.
We now generally favor the following kind of test style:
```JavaScript
add_task(async function test_something() {
...
});
```
over the way where you manually have to call `SimpleTest.finish()` despite only doing non event based testing.
Collaborator
Author
|
It is rather ugly that the taint checks are located in |
Collaborator
Author
|
One side effect of the second commit is the increased number of tests, but I feel that is not a problem. It is rather positive, as it avoids masking some errors in case of exceptions. |
Merged
Before we had a ton of copy and pasted code for the purpose of checking whether some piece of JS code triggers a __taintreport event and whether that has the correct sink. This unifies the handling/setup into one method that is used across our tests now.
leeN
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we have a ton of duplication across the mochitests. Additionally, they contain slight differences, e.g., nullable property access vs hard property access.
This PR aims to unify this.
Tasks to be done:
finish().