Skip to content

Conversation

@Pucek9
Copy link
Contributor

@Pucek9 Pucek9 commented Jan 22, 2026

Closes CXSPA-11884

@Pucek9
Copy link
Contributor Author

Pucek9 commented Jan 22, 2026

Explanation of weird changes:
Updated some libraries in the tool: I initially had problems with glob, and I've upgraded others to maintain some versioning consistency (I don't remember the exact errors - apologize, but in this configuration, it seems to work for both augmented-types and declaration-merging).

Changed paths in scripts was necessary, as clone.sh generated /src/ folder in root of project instead of tools/breaking-changes
Im not sure how it worked before.

Another thing that confused me was the errors thrown due to a missing comma at the end of a property in api-extractor.json‎, which seems absurd (or a leading space in a comment on the next line).

- `/tools/breaking-changes/extract-bundled.ts` - Added normalization, rewrote token generation
- `/tools/breaking-changes/parse.ts` - Added normalization and validation
- `/tools/breaking-changes/common.ts` - Updated TypeAlias rendering
- `/tools/breaking-changes/package.json` - Added `validate` and `test` scripts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `/tools/breaking-changes/package.json` - Added `validate` and `test` scripts


// Skip public_api.d.ts files as they are re-exports
if (fileName === 'public_api') {
return '@spartacus/unknown';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spartacus/unknown?

Comment on lines +113 to +115
previousNode: 'SubscriptionBillingEventModule',
previousImportPath: '@spartacus/subscription-billing/root',
newImportPath: '@spartacus/subscription/billing/root',
Copy link
Contributor

@Platonn Platonn Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MAJOR]
There is no such entrypoint like @spartacus/subscription/billing/root in Spartacus libs.
How it's possible such a fake newImportPath is in our scripts' output?

Note: this comment applies to all libs that had - in their pacakge name, .e.g @spartacus/product-configurator is NOT moved now to @spartacus/product/configurator

Comment on lines +240 to +245
{
node: 'ICON_TYPE',
importPath: '@spartacus/storefront',
comment:
'// TODO:Spartacus - Enum ICON_TYPE has been removed and is no longer part of the public API. ',
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MAJOR]
ICON_TYPE is still part of the @spartacus/storefront api. And there was no intention to remove it.
I guess the generated output in this file might be incorrect also in other places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants