Skip to content

fix: add non-standard default roles to filtering #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lechnerc77 merged 2 commits into from
Oct 21, 2025
Merged

fix: add non-standard default roles to filtering #492

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f92c91
fix: add non-standard default roles to filtering
lechnerc77 Oct 20, 2025
a97d3a6
Merge branch 'main' into fix/default-roles
lechnerc77 Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion internal/btpcli/wrapper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"net/http"
"net/url"
"os"
"slices"
"testing"

"github.com/SAP/terraform-exporter-btp/pkg/tfcleanup/testutils"
Expand Down Expand Up @@ -128,6 +129,11 @@ func GetDefaultRoleCollectionsByDirectory(directoryId string, client *ClientFaca
}

func GetDefaultRolesBySubaccount(subaccountId string, client *ClientFacade) (defaults []string, err error) {
// Role names that are provisioned by default but cannot be identified via standard configuration
var defaultRoleNameSubaccount = []string{
"Application_Frontend_Developer",
}

var roles []string

cliRes, _, err := client.Security.Role.ListBySubaccount(context.Background(), subaccountId)
Expand All @@ -138,7 +144,7 @@ func GetDefaultRolesBySubaccount(subaccountId string, client *ClientFacade) (def

for _, role := range cliRes {
// The roles that are marked as IsReadOnly and contain an empty attribute list are predefined and need not be exported
if role.IsReadOnly && len(role.AttributeList) == 0 {
if role.IsReadOnly && len(role.AttributeList) == 0 || role.IsReadOnly && slices.Contains(defaultRoleNameSubaccount, role.Name) {
roles = append(roles, role.Name)
}
}
Expand Down