SmartTemplateAnalyzer: Add tests for error cases

Author: matz3

test/lib/lbt/analyzer/FioriElementsAnalyzer.js

@@ -266,7 +266,7 @@ test("_analyzeAST: get template name from ast (AMD define)", async (t) => {
 });
 
 test("_analyzeAST: unable to get template name from ast (no TemplateAssembler import)", async (t) => {
-	const code = `sap.ui.define([], // import missing
+	const code = `sap.ui.define(["a"], // import missing
 		function(a, TemplateAssembler){
 		return TemplateAssembler.getTemplateComponent(getMethods,
 		"sap.fe.templates.Page.Component", {

test/lib/lbt/analyzer/SmartTemplateAnalyzer.js

@@ -432,6 +432,67 @@ test("_analyzeAST: get template name from ast (ArrowFunction)", async (t) => {
 	t.is(result, "donkey");
 });
 
+test("_analyzeAST: get template name from ast (AMD define)", async (t) => {
+	const code = `define(["a", "sap/suite/ui/generic/template/lib/TemplateAssembler"], function(a, TemplateAssembler) {
+		return TemplateAssembler.getTemplateComponent(getMethods,
+		"sap.fe.templates.Page.Component", {
+			metadata: {
+				properties: {
+					"templateName": {
+						"type": "string",
+						"defaultValue": "sap.fe.templates.Page.view.Page"
+					}
+				},
+				"manifest": "json"
+			}
+		});});`;
+	const ast = parseUtils.parseJS(code);
+	const analyzer = new SmartTemplateAnalyzer();
+	const templateName = await analyzer._analyzeAST("sap.fe.templates.Page.Component", ast);
+	t.is(templateName, "sap.fe.templates.Page.view.Page");
+});
+
+test("_analyzeAST: unable to get template name from ast (no TemplateAssembler import)", async (t) => {
+	const code = `define(["a"], function(a, TemplateAssembler) { // import missing
+		return TemplateAssembler.getTemplateComponent(getMethods,
+		"sap.fe.templates.Page.Component", {
+			metadata: {
+				properties: {
+					"templateName": {
+						"type": "string",
+						"defaultValue": "sap.fe.templates.Page.view.Page"
+					}
+				},
+				"manifest": "json"
+			}
+		});});`;
+	const ast = parseUtils.parseJS(code);
+	const analyzer = new SmartTemplateAnalyzer();
+	const templateName = await analyzer._analyzeAST("sap.fe.templates.Page.Component", ast);
+	t.is(templateName, "");
+});
+
+test("_analyzeAST: unable to get template name from ast (no module definition)", async (t) => {
+	const code = `myDefine(["a", "sap/suite/ui/generic/template/lib/TemplateAssembler"],
+	function(a, TemplateAssembler) { // unsupported module definition
+		return TemplateAssembler.getTemplateComponent(getMethods,
+		"sap.fe.templates.Page.Component", {
+			metadata: {
+				properties: {
+					"templateName": {
+						"type": "string",
+						"defaultValue": "sap.fe.templates.Page.view.Page"
+					}
+				},
+				"manifest": "json"
+			}
+		});});`;
+	const ast = parseUtils.parseJS(code);
+	const analyzer = new SmartTemplateAnalyzer();
+	const templateName = await analyzer._analyzeAST("sap.fe.templates.Page.Component", ast);
+	t.is(templateName, "");
+});
+
 test("_analyzeAST: get template name from ast (ArrowFunction with implicit return)", async (t) => {
 	const code = `sap.ui.define(["a", "sap/suite/ui/generic/template/lib/TemplateAssembler"],
 	(a, TemplateAssembler) => TemplateAssembler.getTemplateComponent(getMethods,
@@ -452,6 +513,41 @@ test("_analyzeAST: get template name from ast (ArrowFunction with implicit retur
 	t.is(templateName, "sap.fe.templates.Page.view.Page");
 });
 
+test("_analyzeAST: unable to get template name from ast (ArrowFunction with implicit return #1)", async (t) => {
+	const code = `sap.ui.define(["a", "sap/suite/ui/generic/template/lib/TemplateAssembler"],
+	(a, TemplateAssembler) => TemplateAssembler.getTemplateComponent(getMethods,
+		"sap.fe.templates.Page.Component", {
+			metadata: {
+				// No templateName provided
+				"manifest": "json"
+			}
+		}));`;
+	const ast = parseUtils.parseJS(code);
+	const analyzer = new SmartTemplateAnalyzer();
+	const templateName = await analyzer._analyzeAST("sap.fe.templates.Page.Component", ast);
+	t.is(templateName, "");
+});
+
+test("_analyzeAST: unable to get template name from ast (ArrowFunction with implicit return #2)", async (t) => {
+	const code = `sap.ui.define(["a", "sap/suite/ui/generic/template/lib/TemplateAssembler"],
+	(a, TemplateAssembler) => TemplateAssembler.extend(getMethods, // wrong call. should be 'getTemplateComponent'
+		"sap.fe.templates.Page.Component", {
+			metadata: {
+				properties: {
+					"templateName": {
+						"type": "string",
+						"defaultValue": "sap.fe.templates.Page.view.Page"
+					}
+				},
+				"manifest": "json"
+			}
+		}));`;
+	const ast = parseUtils.parseJS(code);
+	const analyzer = new SmartTemplateAnalyzer();
+	const templateName = await analyzer._analyzeAST("sap.fe.templates.Page.Component", ast);
+	t.is(templateName, "");
+});
+
 test("_analyzeAST: get template name from ast (async ArrowFunction)", async (t) => {
 	const code = `sap.ui.define(["a", "sap/suite/ui/generic/template/lib/TemplateAssembler"],
 	async (a, TemplateAssembler) => TemplateAssembler.getTemplateComponent(getMethods,