[INTERNAL] analyzeLibraryJS: Ignoring SpreadElements in library.js

Author: flovogt

lib/lbt/analyzer/analyzeLibraryJS.js

@@ -26,8 +26,14 @@ async function analyze(resource) {
 				node.arguments.length === 1 &&
 				node.arguments[0].type === Syntax.ObjectExpression ) {
 			node.arguments[0].properties.forEach( (prop) => {
+				if (prop.type === Syntax.SpreadElement) {
+					// TODO: Support interpreting SpreadElements
+					return;
+				}
+
 				const key = getPropertyKey(prop);
 				const value = prop.value;
+
 				if ( key === "noLibraryCSS" &&
 						(value.type === Syntax.Literal && typeof value.value === "boolean") ) {
 					libInfo.noLibraryCSS = value.value;

test/lib/lbt/analyzer/analyzeLibraryJS.js

@@ -13,47 +13,49 @@ function createMockResource(content, path) {
 	};
 }
 
-test("analyze: library.js with non supported property", async (t) => {
-	const libraryJS = `sap.ui.define([
-       'sap/ui/core/Core',
-   ], function(Core) {
-
-       "use strict";
-
-       sap.ui.getCore().initLibrary({
-           name : "library.test",
-		   version: "1.0.0",
-		   customProperty1: "UI5",
-		   dependencies : ["sap.ui.core"],
-		   types: [
-			   "library.test.ButtonType",
-			   "library.test.DialogType",
-		   ],
-		   interfaces: [
-			   "library.test.IContent",
-		   ],
-		   controls: [
-			   "library.test.Button",
-			   "library.test.CheckBox",
-			   "library.test.Dialog",
-			   "library.test.Input",
-			   "library.test.Label",
-			   "library.test.Link",
-			   "library.test.Menu",
-			   "library.test.Text"
-		   ],
-		   elements: [
-			   "library.test.MenuItem"
-		   ],
-		   extensions: {
-			   customExtension: "UI5"
-		   },
-           customProperty2: "UI5"
-       });
-
-       return thisLib;
+test.afterEach.always((t) => {
+	mock.stopAll();
+	sinon.restore();
+});
 
-   });`;
+test.serial("analyze: library.js with non supported property", async (t) => {
+	const libraryJS = `
+sap.ui.define([
+	'sap/ui/core/Core',
+], function(Core) {
+	"use strict";
+	sap.ui.getCore().initLibrary({
+		name : "library.test",
+		version: "1.0.0",
+		customProperty1: "UI5",
+		dependencies : ["sap.ui.core"],
+		types: [
+			"library.test.ButtonType",
+			"library.test.DialogType",
+		],
+		interfaces: [
+			"library.test.IContent",
+		],
+		controls: [
+			"library.test.Button",
+			"library.test.CheckBox",
+			"library.test.Dialog",
+			"library.test.Input",
+			"library.test.Label",
+			"library.test.Link",
+			"library.test.Menu",
+			"library.test.Text"
+		],
+		elements: [
+			"library.test.MenuItem"
+		],
+		extensions: {
+			customExtension: "UI5"
+		},
+		customProperty2: "UI5"
+	});
+	return thisLib;
+});`;
 
 	const librayJSPath = "library/test/library.js";
 	const logger = require("@ui5/logger");
@@ -76,3 +78,40 @@ test("analyze: library.js with non supported property", async (t) => {
 		"Unexpected property: 'customProperty2' in sap.ui.getCore().initLibrary call in 'library/test/library.js'",
 		"The error log message of the first call is correct");
 });
+
+
+test.serial("analyze: library.js with SpreadExpression", async (t) => {
+	const libraryJS = `
+sap.ui.define([
+	'sap/ui/core/Core',
+], function(Core) {
+	"use strict";
+	const myExtensions = {myProperty1: "Value1", myProperty2: "Value2"};
+	sap.ui.getCore().initLibrary({
+		...myExtensions,
+		name : "library.test",
+		version: "1.0.0",
+		elements: [
+			"library.test.MenuItem"
+		],
+	});
+	return thisLib;
+});`;
+
+	const librayJSPath = "library/test/library.js";
+	const logger = require("@ui5/logger");
+	const errorLogStub = sinon.stub();
+	const myLoggerInstance = {
+		error: errorLogStub
+	};
+	sinon.stub(logger, "getLogger").returns(myLoggerInstance);
+	const analyzeLibraryJSWithStubbedLogger = mock.reRequire("../../../../lib/lbt/analyzer/analyzeLibraryJS");
+
+	const mockResource = createMockResource(libraryJS, librayJSPath);
+
+	const result = await analyzeLibraryJSWithStubbedLogger(mockResource);
+
+	t.is(errorLogStub.callCount, 0, "Error log is not called");
+	t.is(result.elements[0], "library.test.MenuItem", "The libraryjs is correctly analyzed");
+});
+