Skip to content

[INTERNAL] Task generateLibraryPreload: Exclude component preload artefacts from library preload #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2022
Merged

[INTERNAL] Task generateLibraryPreload: Exclude component preload artefacts from library preload #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cb0915
[INTERNAL] Task generateLibraryPreload: Exclude component preload art…
flovogt May 23, 2022
30880a1
[INTERNAL] adjust tests
flovogt Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/tasks/bundlers/generateLibraryPreload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ function getDefaultLibraryPreloadFilters(namespace, excludes) {
const filters = [
`${namespace}/`,
`${namespace}/**/manifest.json`,
`!${namespace}/*-preload.js`, // exclude all bundles
`!${namespace}/**/*-preload.js`, // exclude all bundles
`!${namespace}/designtime/`,
`!${namespace}/**/*.designtime.js`,
`!${namespace}/**/*.support.js`
Expand Down
16 changes: 8 additions & 8 deletions test/lib/tasks/bundlers/generateLibraryPreload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ test.serial("generateLibraryPreload", async (t) => {
filters: [
"my/lib/",
"my/lib/**/manifest.json",
"!my/lib/*-preload.js",
"!my/lib/**/*-preload.js",
"!my/lib/designtime/",
"!my/lib/**/*.designtime.js",
"!my/lib/**/*.support.js",
Expand Down Expand Up @@ -354,7 +354,7 @@ test.serial("generateLibraryPreload for sap.ui.core (w/o ui5loader.js)", async (
filters: [
"sap/ui/core/",
"sap/ui/core/**/manifest.json",
"!sap/ui/core/*-preload.js",
"!sap/ui/core/**/*-preload.js",
"!sap/ui/core/designtime/",
"!sap/ui/core/**/*.designtime.js",
"!sap/ui/core/**/*.support.js",
Expand Down Expand Up @@ -636,7 +636,7 @@ test.serial("generateLibraryPreload for sap.ui.core (/w ui5loader.js)", async (t
filters: [
"sap/ui/core/",
"sap/ui/core/**/manifest.json",
"!sap/ui/core/*-preload.js",
"!sap/ui/core/**/*-preload.js",
"!sap/ui/core/designtime/",
"!sap/ui/core/**/*.designtime.js",
"!sap/ui/core/**/*.support.js",
Expand Down Expand Up @@ -970,7 +970,7 @@ test.serial("generateLibraryPreload for sap.ui.core with old specVersion defined
filters: [
"sap/ui/core/",
"sap/ui/core/**/manifest.json",
"!sap/ui/core/*-preload.js",
"!sap/ui/core/**/*-preload.js",
"!sap/ui/core/designtime/",
"!sap/ui/core/**/*.designtime.js",
"!sap/ui/core/**/*.support.js",
Expand Down Expand Up @@ -1126,7 +1126,7 @@ test.serial("generateLibraryPreload for sap.ui.core with own bundle configuratio
filters: [
"sap/ui/core/",
"sap/ui/core/**/manifest.json",
"!sap/ui/core/*-preload.js",
"!sap/ui/core/**/*-preload.js",
"!sap/ui/core/designtime/",
"!sap/ui/core/**/*.designtime.js",
"!sap/ui/core/**/*.support.js",
Expand Down Expand Up @@ -1293,7 +1293,7 @@ test.serial("generateLibraryPreload for sap.ui.core with own bundle configuratio
filters: [
"sap/ui/core/",
"sap/ui/core/**/manifest.json",
"!sap/ui/core/*-preload.js",
"!sap/ui/core/**/*-preload.js",
"!sap/ui/core/designtime/",
"!sap/ui/core/**/*.designtime.js",
"!sap/ui/core/**/*.support.js",
Expand Down Expand Up @@ -1482,7 +1482,7 @@ test.serial("generateLibraryPreload with excludes", async (t) => {
filters: [
"my/lib/",
"my/lib/**/manifest.json",
"!my/lib/*-preload.js",
"!my/lib/**/*-preload.js",
"!my/lib/designtime/",
"!my/lib/**/*.designtime.js",
"!my/lib/**/*.support.js",
Expand Down Expand Up @@ -1553,7 +1553,7 @@ test.serial("generateLibraryPreload with invalid excludes", async (t) => {
filters: [
"my/lib/",
"my/lib/**/manifest.json",
"!my/lib/*-preload.js",
"!my/lib/**/*-preload.js",
"!my/lib/designtime/",
"!my/lib/**/*.designtime.js",
"!my/lib/**/*.support.js"
Expand Down