[FIX] byGlob: Re-included exclude patterns do not add resources to the result set themselves #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e result set themselves The current handling of glob exclude patterns may lead to resources being added to a result set even though they do not match the provided glob patterns. This can happen if a negated exclude pattern is provided. Resolves https://github.com/SAP/ui5-builder/issues/367
RandomByte
force-pushed
the
glob-fix-included-excludes
branch
from
31f56c0 to
29e29ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current handling of glob exclude patterns may lead to resources
being added to a result set even though they do not match the provided
glob patterns. This can happen if a negated exclude pattern is provided.
Resolves https://github.com/SAP/ui5-builder/issues/367
Depends on mrmlnc/fast-glob#86