-
Notifications
You must be signed in to change notification settings - Fork 279
fix(ui5-input): prevent typeahead during IME composition #11976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aleksandar-terziev
wants to merge
10
commits into
main
Choose a base branch
from
input-text-composition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+38
−1
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1c59e4a
fix(ui5-input): prevent typeahead during IME composition
aleksandar-terziev e0392f4
Merge branch 'main' into input-text-composition
aleksandar-terziev 1e219b9
Merge branch 'main' into input-text-composition
aleksandar-terziev 601f2d1
Merge branch 'main' into input-text-composition
aleksandar-terziev c8ad836
Merge branch 'main' into input-text-composition
aleksandar-terziev efbac5d
Merge branch 'main' into input-text-composition
aleksandar-terziev 8287bc1
Merge branch 'main' into input-text-composition
aleksandar-terziev 2d94703
Merge branch 'main' into input-text-composition
aleksandar-terziev bf1ea94
Merge branch 'main' into input-text-composition
aleksandar-terziev 29bd85b
Merge branch 'main' into input-text-composition
aleksandar-terziev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
place this in the template file
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, Preact does not support composition events so we need this workaround until Preact resolves the bug