Skip to content

fix(framework): explicitly allow setting sap-ui-themeRoot #12030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vladitasev
Copy link
Contributor

This change requires developers to explicitly opt-in for allowing data-sap-themeRoot to be configured by URL. Other methods (configuration script, calling setThemeRoot directly) are not affected.

BREAK ING CHANGE:

For security reasons, setting the themeRoot parameter via URL must be explicitly allowed by calling:

import { allowThemeRootUrl } from "@ui5/webcomponents-base/dist/config/ThemeRoot.js";
allowThemeRootUrl(true);

Unless this method is called with true, setting data-sap-themeRoot in the URL has no effect and will produce a console warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant