fix(framework): explicitly allow setting sap-ui-themeRoot #12030
+33
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change requires developers to explicitly opt-in for allowing
data-sap-themeRoot
to be configured by URL. Other methods (configuration script, callingsetThemeRoot
directly) are not affected.BREAK ING CHANGE:
For security reasons, setting the
themeRoot
parameter via URL must be explicitly allowed by calling:Unless this method is called with
true
, settingdata-sap-themeRoot
in the URL has no effect and will produce a console warning.