fix(ui5-color-palette): adjust keyboard navigation #12107
+244
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes keyboard navigation issues in the UI5 ColorPalette component, specifically addressing Home/End key behavior and mouse interaction handling. The changes ensure proper navigation focus management in both regular and popover modes.
- Restricts Home/End keyboard shortcuts to work only in popover mode as per specification
- Updates navigation index on mousedown events to maintain proper focus state
- Adds comprehensive test coverage for keyboard navigation scenarios
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ColorPaletteTemplate.tsx | Adds mousedown event handler to template |
| ColorPalette.ts | Implements core navigation logic fixes and adds helper methods |
| ColorPalettePopover.commands.ts | New Cypress commands for popover testing |
| commands.ts | Imports new popover test commands |
| ColorPalettePopover.cy.tsx | Comprehensive test suite for keyboard navigation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HomeandEndkeyboard shortcuts now work only in palette popover mode.mousedownevent.HomeandEndkeyboard shortcuts now work in popover mode as per specification.Fixes: #8744
Fixes: #11439