Skip to content

Frame Shift Module to Correct Timing in Data - PR For Develop#154

Merged
kjplows merged 9 commits intodevelopfrom
lnguyen/frame_shift_pr_dev
Sep 12, 2025
Merged

Frame Shift Module to Correct Timing in Data - PR For Develop#154
kjplows merged 9 commits intodevelopfrom
lnguyen/frame_shift_pr_dev

Conversation

@VCLanNguyen
Copy link
Contributor

@VCLanNguyen VCLanNguyen commented Aug 30, 2025

New Standard Record Classes to Store Timing Correction in SBND Data.
Full description can be found in docdb: https://sbn-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=43090

Required by the following PRs:
sbnobj dev: SBNSoftware/sbnobj#142
sbnanaobj dev: #154
sbndcode dev: SBNSoftware/sbndcode#804
sbncode dev: SBNSoftware/sbncode#562

@kjplows
Copy link
Contributor

kjplows commented Sep 4, 2025

trigger build ci_ref=v10_06_02 LArSoft/lar*@LARSOFT_SUITE_v10_09_00

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows
Copy link
Contributor

kjplows commented Sep 11, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_09_00

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 12, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 12, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 12, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 12, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 12, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 12, 2025
Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as this is a copy of PR #154, this one is approved.

Note that I did not check that they are the same — the only check I performed is that the checksums match between the two pull requests.

@kjplows kjplows moved this from Open pull requests to To merge in SBN software development Sep 12, 2025
@kjplows kjplows merged commit 2e43fe4 into develop Sep 12, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Sep 12, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Sep 12, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Sep 18, 2025
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in PR archaeology Jan 16, 2026
@kjplows kjplows added this to the v10_10_02 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done
Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

4 participants